Skip to content

.Net: Copy code related to AzureChatCompletionSeervice from Connectors.OpenAI to Connectors.AzureOpenAI - #6906

Merged
SergeyMenshykh merged 2 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:move-azureopenai-code
Jun 24, 2024
Merged

.Net: Copy code related to AzureChatCompletionSeervice from Connectors.OpenAI to Connectors.AzureOpenAI #6906
SergeyMenshykh merged 2 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:move-azureopenai-code

Conversation

@SergeyMenshykh

Copy link
Copy Markdown
Contributor

Motivation and Context

As a first step in migrating AzureOpenAIConnector to Azure AI SDK v2, all code related to AzureOpenAIChatCompletionService, including unit tests, is copied from the Connectors.OpenAI project to the Connectors.AzureOpenAI project as-is, with only the structural modifications described below and no logical modifications. This is a preparatory step before refactoring the AzureOpenAIChatCompletionService to use Azure SDK v2.

Description

This PR does the following:

  1. Copies the AzureOpenAIChatCompletionService class and all its dependencies to the Connectors.AzureOpenAI project as they are, with no code changes.
  2. Copies all existing unit tests related to the AzureOpenAIChatCompletionService service and its dependencies to the Connectors.AzureOpenAI.UnitTests project.
  3. Renames some files in the Connectors.AzureOpenAI project so that their names begin with AzureOpenAI instead of OpenAI.
  4. Changes namespaces in the copied files from Microsoft.SemanticKernel.Connectors.OpenAI to Microsoft.SemanticKernel.Connectors.AzureOpenAI.

Related to the "Move reusable code from existing Microsoft.SemanticKernel.Connectors.OpenAI project to the new project" task of
the #6864 issue.

Contribution Checklist

@SergeyMenshykh SergeyMenshykh added .NET Issue or Pull requests regarding .NET code ai connector Anything related to AI connectors labels Jun 21, 2024
@SergeyMenshykh SergeyMenshykh self-assigned this Jun 21, 2024
@SergeyMenshykh
SergeyMenshykh requested a review from a team as a code owner June 21, 2024 17:22
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the kernel Issues or pull requests impacting the core kernel label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai connector Anything related to AI connectors kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants