.Net: AzureOpenAIChatCompletionService Functionality Cleanup - #7024
Merged
SergeyMenshykh merged 3 commits intoJul 1, 2024
Conversation
1. Rename classes, class members and variables of the service and the model classes to reflect their actual purpose/functionality. 2. Remove unnecessary classes. 3. Make integration tests more resilient to 429 responses.
Mark Wallace (markwallace-microsoft)
added
.NET
github-actions
Bot
changed the title
SergeyMenshykh
requested review from
Mark Wallace (markwallace-microsoft) and
Roger Barreto (rogerbarreto)
July 1, 2024 12:04
Roger Barreto (rogerbarreto)
approved these changes
Jul 1, 2024
Roger Barreto (rogerbarreto)
left a comment
Roger Barreto (rogerbarreto)
left a comment
Member
There was a problem hiding this comment.
nit. Rename internal/private method.
Roger Barreto (rogerbarreto)
approved these changes
Jul 1, 2024
Mark Wallace (markwallace-microsoft)
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is a follow-up to the one that migrated the AzureOpenAIChatCompletionService class to Azure AI SDK v2 but did not properly refactor it, leaving class, member, and variable names unchanged to minimize the number of changes and simplify the code review process.
Description
This PR does the following:
1. No functional changes - just deletion and renaming.
2. Renames ClientCore class methods and method variables to reflect their actual purpose/functionality.
3. Renames class members of other classes related to and used by the AzureOpenAIChatCompletionService.
4. Renames AzureOpenAIPromptExecutionSettings class to AzureOpenAIChatCompletionExecutionSettings to indicate that it belongs to the chat completion service and not to any other one.
5. Removes the AzureOpenAIStreamingTextContent class used by the text generation service, which has been deprecated and is not supported by Azure AI SDK v2.
6. Improves the resiliency of AzureOpenAIChatCompletionService integration tests by using a base integration class with a preconfigured resilience handler to handle 429 responses.