Skip to content

.Net: OpenAI V2 - Migrate Audio Services Phase 04 - #7029

Merged
Roger Barreto (rogerbarreto) merged 18 commits into
microsoft:feature-connectors-openaifrom
rogerbarreto:features/openai-v2-phase04
Jul 2, 2024
Merged

.Net: OpenAI V2 - Migrate Audio Services Phase 04#7029
Roger Barreto (rogerbarreto) merged 18 commits into
microsoft:feature-connectors-openaifrom
rogerbarreto:features/openai-v2-phase04

Conversation

@rogerbarreto

Copy link
Copy Markdown
Member

Motivation and Context

  • Audio to Text Services + UT + IT
  • Text to Audio Services + UT + IT
  • Added missing extension methods for Breaking Glass OpenAIClient
  • Moved ClientResultExtension + UT to utilities
  • Added and Moved Extensions + UT

@rogerbarreto
Roger Barreto (rogerbarreto) requested a review from a team as a code owner July 1, 2024 17:39
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 1, 2024
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore .AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore .AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore .TextToAudio.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore .AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/OpenAIAudioToTextExecutionSettings.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/OpenAIAudioToTextExecutionSettings.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.TextToAudio.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.AudioToText.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.OpenAIV2/Core/ClientCore.AudioToText.cs Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SergeyMenshykh , moved this to be an Utility and the test was moved to SemanticKernel.UnitTests, removed the test from both connectors.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider doing it in a separate PR next time to minimize PR sizes and to have them reviewed faster.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider doing it in a separate PR next time to minimize PR sizes and to have them reviewed faster.

@rogerbarreto
Roger Barreto (rogerbarreto) merged commit 3ebe6ef into microsoft:feature-connectors-openai Jul 2, 2024
@rogerbarreto
Roger Barreto (rogerbarreto) deleted the features/openai-v2-phase04 branch February 13, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants