Skip to content

.Net: Migrate AzureOpenAITextEmbeddingGenerationService to Azure AI SDK v2 - #7030

Merged
SergeyMenshykh merged 5 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:migrate-text-embedding-generation-service-1
Jul 2, 2024
Merged

.Net: Migrate AzureOpenAITextEmbeddingGenerationService to Azure AI SDK v2#7030
SergeyMenshykh merged 5 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:migrate-text-embedding-generation-service-1

Conversation

@SergeyMenshykh

@SergeyMenshykh SergeyMenshykh commented Jul 1, 2024

Copy link
Copy Markdown
Contributor

Motivation, Context and Description

This PR migrates the AzureOpenAITextEmbeddingGenerationService to Azure AI SDK v2:

  1. The AzureOpenAITextEmbeddingGenerationService class is updated to use the new AzureOpenAIClient from Azure AI SDK v2.
  2. Service collection and kernel builder extension methods for registering the service are copied to the new Connectors.AzureOpenAI project.
  3. Unit tests are added (copied and adapted) for the service and the extension methods.
  4. Integration tests are added (copied and adapted) for the service.

@SergeyMenshykh SergeyMenshykh self-assigned this Jul 1, 2024
@SergeyMenshykh
SergeyMenshykh requested a review from a team as a code owner July 1, 2024 17:44
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 1, 2024
rogerbarreto
Roger Barreto (rogerbarreto) approved these changes Jul 1, 2024
View reviewed changes
Comment thread ...t/src/Connectors/Connectors.AzureOpenAI/Extensions/AzureOpenAIServiceCollectionExtensions.cs Outdated
Comment thread .../Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextEmbeddingGenerationServiceTests.cs Outdated
Comment thread .../Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextEmbeddingGenerationServiceTests.cs Outdated
Comment thread dotnet/src/IntegrationTestsV2/Connectors/AzureOpenAI/AzureOpenAITextEmbeddingTests.cs
@SergeyMenshykh
SergeyMenshykh merged commit 2941245 into microsoft:feature-connectors-openai Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
@westey-m westey (westey-m) westey-m approved these changes
@markwallace-microsoft Mark Wallace (markwallace-microsoft) Awaiting requested review from markwallace-microsoft

Assignees

@SergeyMenshykh SergeyMenshykh

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

Semantic Kernel
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SergeyMenshykh @rogerbarreto @westey-m @markwallace-microsoft