Skip to content

.Net: Split ClientCore class - #7060

Merged
SergeyMenshykh merged 2 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:chat-completion-serviice-clean-up-3
Jul 2, 2024
Merged

.Net: Split ClientCore class#7060
SergeyMenshykh merged 2 commits into
microsoft:feature-connectors-openaifrom
SergeyMenshykh:chat-completion-serviice-clean-up-3

Conversation

@SergeyMenshykh

Copy link
Copy Markdown
Contributor

Motivation and Context

The ClientCore class has absorbed functionality relevant to different Azure OpenAI-related services. As a first step to reduce its size, it makes sense to split it into small chunks, where each chunk would be related to a service that uses it. Later, we can move those chunks to the services themselves.

Description

This PR does the following:

  1. Does not change any logic in any of the services.
  2. Splits the ClientCore class into ClientCore.ChatCompletion and ClientCore.Embeddings files.
  3. Refactors the AzureOpenAIChatCompletionService and AzureOpenAITextEmbeddingGenerationService to use the relevant ClientCore pieces.
  4. Removes the AzureOpenAIClientCore class

@SergeyMenshykh
SergeyMenshykh requested a review from a team as a code owner July 2, 2024 15:41
@SergeyMenshykh SergeyMenshykh self-assigned this Jul 2, 2024
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 2, 2024
Comment thread dotnet/src/Connectors/Connectors.AzureOpenAI/Core/ClientCore.ChatCompletion.cs Outdated
Comment thread dotnet/src/Connectors/Connectors.AzureOpenAI/Core/ClientCore.cs
@SergeyMenshykh
SergeyMenshykh merged commit f266504 into microsoft:feature-connectors-openai Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants