.Net: Tidying up AzureOpenAIChatCompletionService - #7073
Merged
SergeyMenshykh merged 1 commit intoJul 3, 2024
Merged
Conversation
SergeyMenshykh
requested review from
Mark Wallace (markwallace-microsoft) and
Roger Barreto (rogerbarreto)
July 3, 2024 09:26
Mark Wallace (markwallace-microsoft)
added
.NET
SergeyMenshykh
changed the title
westey (westey-m)
approved these changes
Jul 3, 2024
Roger Barreto (rogerbarreto)
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
This PR fixes a small issue that would occur if the LLM started calling tools that are not functions. Additionally, it renames the
openAIClientparameter of theAzureOpenAIChatCompletionServiceclass constructor toazureOpenAIClientto keep the name consistent with its type. It also renames theAzureOpenAIChatMessageContent.GetOpenAIFunctionToolCallsmethod toGetFunctionToolCallsbecause the old one is not relevant anymore. The last two changes are breaking changes and it will be decided in the scope of the #7053 issue whether to keep them or roll them back.