ADR Agents - Assistant V2 Support - #7215
Merged
Merged
Conversation
Chris (crickman)
added
PR: ready for review
Evan Mattson (moonbox3)
approved these changes
Jul 22, 2024
Ben Thomas (alliscode)
approved these changes
Jul 23, 2024
Chris (crickman)
removed
the
PR: ready for review
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Open AI has release the _Assistants V2_ API. This builds on top of the V1 _assistant_ concept, but also invalidates certain V1 features. In addition, the _dotnet_ API that supports _Assistant V2_ features is entirely divergent on the `Azure.AI.OpenAI.Assistants` SDK that is currently in use. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ADR describes changes to `Microsoft.SemanticKernel.Agents.OpenAI` project / package. Changes prototyped in this PR: microsoft#7126 PR completion is gated by the V2 connector migration work due to versioning constraints. > ADR Reviewed on July 18th, 2024 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Open AI has release the Assistants V2 API. This builds on top of the V1 assistant concept, but also invalidates certain V1 features. In addition, the dotnet API that supports Assistant V2 features is entirely divergent on the
Azure.AI.OpenAI.AssistantsSDK that is currently in use.Description
ADR describes changes to
Microsoft.SemanticKernel.Agents.OpenAIproject / package.Changes prototyped in this PR: #7126
PR completion is gated by the V2 connector migration work due to versioning constraints.
Contribution Checklist