Add FileCompression skill - #82
Merged
Lee Miller (lemillermicrosoft) merged 10 commits intoMar 30, 2023
Merged
Conversation
Closed
Shawn Callegari (shawncal)
suggested changes
Mar 15, 2023
Contributor
|
Can we put this project under the samples/skills folder? |
Contributor
Author
Shawn Callegari (@shawncal) told me one big difference is that src/SemanticKernel.Skills skills go out in Nugets and therefore need more support down the line and as such, when things are still in flux (like they are now), going with samples/skills makes more sense. Going with your suggestion, Abby Harrison (@awharrison-28) |
Adrian Bonar (adrianwyatt)
added
the
PR: feedback to address
Gil LaHaye (glahaye)
added
PR: ready for review
Adrian Bonar (adrianwyatt)
removed the request for review
from Shawn Callegari (shawncal)
March 21, 2023 23:59
Member
|
Is this needed for |
Contributor
Author
It's a "nice-to-have" for the memory sample. Not needed now. |
Adrian Bonar (adrianwyatt)
requested changes
Mar 22, 2023
Adrian Bonar (adrianwyatt)
added
PR: feedback to address
Gil LaHaye (glahaye)
requested review from
Adrian Bonar (adrianwyatt) and
Shawn Callegari (shawncal)
March 27, 2023 23:13
Gil LaHaye (glahaye)
removed
the
PR: feedback to address
Gil LaHaye (glahaye)
added
the
PR: ready for review
Adrian Bonar (adrianwyatt)
enabled auto-merge (squash)
March 27, 2023 23:29
Adrian Bonar (adrianwyatt)
previously approved these changes
Mar 27, 2023
Lee Miller (lemillermicrosoft)
previously approved these changes
Mar 30, 2023
Lee Miller (lemillermicrosoft)
left a comment
Lee Miller (lemillermicrosoft)
left a comment
Member
There was a problem hiding this comment.
Pre-approval pending merge/rebase.
Shawn Callegari (shawncal)
previously approved these changes
Mar 30, 2023
auto-merge was automatically disabled
March 30, 2023 19:35
Head branch was pushed to by a user without write access
Gil LaHaye (glahaye)
dismissed stale reviews from Shawn Callegari (shawncal), Lee Miller (lemillermicrosoft), and Adrian Bonar (adrianwyatt)
via
March 30, 2023 19:35
79389bb
Lee Miller (lemillermicrosoft)
approved these changes
Mar 30, 2023
Desmond Howard (dehoward)
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
**Motivation and Context** We want to be able to compress and decompress file. **Description** Add the FileCompressionSkill in dotnet samples folder
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We would like to show in the webapp some of the AI service options/configurations we select for our webapi. ### Description 1. Add an OptionsController to allow the webapp to pull (non-secretive) configurations from the backend. 2. Webapp to retrieve memories storage option from the webapi and show it in the documents tab.  <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We want to be able to compress and decompress file.
Description
Add the FileCompressionSkill in dotnet samples folder
Contribution Checklist