Skip to content

Mem reversion - #95

Closed
Gil LaHaye (glahaye) wants to merge 47 commits into
microsoft:mainfrom
craigomatic:mem-reversion
Closed

Mem reversion#95
Gil LaHaye (glahaye) wants to merge 47 commits into
microsoft:mainfrom
craigomatic:mem-reversion

Conversation

@glahaye

Copy link
Copy Markdown
Contributor

Remove memory changes not needed by upcoming sample

Adding Relevance Slider and Send Button to QnA Chat
Remove IFileSystemConnector changes
Remove comment
1. Based on some feedback Shawn posted in another PR I think we should make CodeSkill into a sample project (GitHubExampleSkill) rather than publish it as a nuget package. I have the changes made for this.
2. Also change the messages in the UI to reflect what the sample is doing.
3. Fixes:
    - Spinner working
    - Disable download button while downloading
    - Add a useEffect to add the response to the ChatHistory
4. One experimental change which only summarises files above a certain file size. This saves us some API calls so the .md files can be summarised in ~30 secs (as opposed to ~60 secs)
…rror_msgs

Better error messages for sample 4
- Remove Code.Skill
- Add File label
@lemillermicrosoft

Copy link
Copy Markdown
Member

How is this different than #94? Do we need both?

@craigomatic

Copy link
Copy Markdown
Contributor

How is this different than #94? Do we need both?

We can abandon this PR

@glahaye

Copy link
Copy Markdown
Contributor Author

Closing this PR - Changes are in PR #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants