Second batch for Mac M1 (mainly) changes proposal to make the whole#280
Merged
mjp41 merged 1 commit intomicrosoft:masterfrom Feb 11, 2021
Merged
Second batch for Mac M1 (mainly) changes proposal to make the whole#280mjp41 merged 1 commit intomicrosoft:masterfrom
mjp41 merged 1 commit intomicrosoft:masterfrom
Conversation
devnexen
force-pushed
the
mac_m1_fix_2
branch
from
e33b318 to
42da8c7
Compare
mjp41
reviewed
Feb 9, 2021
Member
mjp41
left a comment
mjp41
left a comment
There was a problem hiding this comment.
I don't know these APIs, but could you clarify a little for me please. Thanks
src/pal/pal_apple.h
Outdated
| { | ||
| SNMALLOC_ASSERT( | ||
| is_aligned_block<PALBSD::page_size>(p, size) || (zero_mem == NoZero)); | ||
| os_unfair_lock lck = OS_UNFAIR_LOCK_INIT; |
Member
There was a problem hiding this comment.
Not sure if there are some crazy macro tricks here, but it looks like it should be static?
Suggested change
| os_unfair_lock lck = OS_UNFAIR_LOCK_INIT; | |
| static os_unfair_lock lck = OS_UNFAIR_LOCK_INIT; |
devnexen
force-pushed
the
mac_m1_fix_2
branch
2 times, most recently
from
05480d5 to
0b50911
Compare
mjp41
approved these changes
Feb 10, 2021
src/pal/pal_apple.h
Outdated
|
|
||
| # include <errno.h> | ||
| # include <mach/vm_statistics.h> | ||
| # include <os/lock.h> |
work more realibly, in both mono and multi thread contexts.
devnexen
force-pushed
the
mac_m1_fix_2
branch
from
0b50911 to
f018573
Compare
davidchisnall
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work more realibly, in both mono and multi thread contexts.