POSIX_COMMIT_CHECKS adding for apple.#284
Conversation
|
@devnexen thanks for thinking about this. You also need the equivalent to https://github.com/microsoft/snmalloc/blob/master/src/pal/pal_bsd.h#L42-L44 to simulate actually removing the pages from being accessible. This is actually more important than the memset. |
|
Yes I know but unfortunately func-malloc* tests abort with it. |
|
Does it do that if we disable calling the |
|
Unfortunately still does not still work (on Mac M1/ARM it should work on Mac Intel). |
d73e713 to
fa14947
Compare
|
With actual code both work under Mac Intel and ARM |
mjp41
left a comment
There was a problem hiding this comment.
LGTM to me, but Clang format is unhappy
https://dev.azure.com/snmalloc/snmalloc/_build/results?buildId=1308&view=logs&j=fb683405-d979-52da-6de9-2541dff429a6&t=f66a877f-3a0c-5131-ec8c-e97d54dcc0fe
@davidchisnall, any comments?
d9311a8 to
54da79f
Compare
No description provided.