This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Int test updates#482
Merged
Merged
Conversation
Contributor
|
Issues
======
+ Solved 4
See the complete overview on Codacy |
Closed
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
kushagraThapar
approved these changes
Feb 7, 2020
kushagraThapar
left a comment
kushagraThapar
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this change, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestRepositoryConfig configuration allows for specifying the cosmos database to use for integration tests via the
cosmosdb.databaseproperty name. This minimizes the number of collections created which is very useful if you don't have unlimited Azure credits. Instead of injectingcosmosdb.uriandcosmosdb.keyand manually creating CosmosDbConfig, this PR updates those files to apply TestRepositoryConfig and autowire the CosmosDbConfig.In addition, RoleRepositoryCollectionIT is updated to add assertions.