fix: properly process result of extract() which is an object instead of array - #76
Merged
Merged
Conversation
Hotell
changed the title
Hotell
marked this pull request as ready for review
March 12, 2025 15:42
sunilsurana
reviewed
Mar 25, 2025
| children: PropTypes.any, | ||
| steps: PropTypes.array, | ||
| isStowrWrightComponent: PropTypes.bool | ||
| isStowrWrightComponent: PropTypes.bool, |
Contributor
There was a problem hiding this comment.
Is it common practice to have "," EOL char for the last property of JSON?
Author
There was a problem hiding this comment.
fyi that's not json - outcome of prettier -w , trailing commas are part of ECMA standard and JSONC standard AFAIR
Contributor
There was a problem hiding this comment.
Cool, didnt know about that.
Hotell
force-pushed
the
fix/get-stories-v2
branch
from
March 25, 2025 14:20
3f704a7 to
619a38f
Compare
sunilsurana
approved these changes
Mar 25, 2025
Contributor
|
Published in storywright@0.0.27-storybook7.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs
Changes
when
--stepsApi=parametersis used stories processing works as expectedRelated Issues
--stepsApiconfiguration flag for storybook v8, v9 and vNext support #74