Skip to content

Update omegaconf version to 2.3.0#631

Merged
abuccts merged 8 commits into
microsoft:mainfrom
RyoYang:yangwang1/fix-omegaconf
Jul 23, 2024
Merged

Update omegaconf version to 2.3.0#631
abuccts merged 8 commits into
microsoft:mainfrom
RyoYang:yangwang1/fix-omegaconf

Conversation

@RyoYang

@RyoYang RyoYang commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Update omegaconf version to 2.3.0 as omegaconf 2.0.6 has a non-standard dependency specifier PyYAML>=5.1.*. pip 24.1 will enforce this behaviour change.
Discussion can be found at pypa/pip#12063

image

@RyoYang
RyoYang requested a review from a team as a code owner July 11, 2024 12:15
Comment thread superbench/runner/runner.py
@codecov

codecov Bot commented Jul 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (7435f10) to head (86138e2).

Files Patch % Lines
superbench/runner/runner.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   85.79%   85.78%   -0.02%     
==========================================
  Files          97       97              
  Lines        6915     6920       +5     
==========================================
+ Hits         5933     5936       +3     
- Misses        982      984       +2     
Flag Coverage Δ
cpu-python3.6-unit-test 71.59% <93.75%> (-0.01%) ⬇️
cpu-python3.7-unit-test 71.59% <93.75%> (-0.01%) ⬇️
cpu-python3.8-unit-test 71.62% <93.75%> (-0.40%) ⬇️
cuda-unit-test 83.86% <93.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread setup.py

@cp5555 cp5555 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange to set the upper version

@cp5555 cp5555 mentioned this pull request Jul 23, 2024
22 tasks
@yukirora

Copy link
Copy Markdown
Contributor

Is this change compatible with the old pip like 22.0.1?

@RyoYang

RyoYang commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

Is this change compatible with the old pip like 22.0.1?
It should be compatible, cpu-unit-test pipeline (Job python3.6) passed all ut and it used a lower version of pip 21.2.4.

@abuccts
abuccts merged commit 9a3ce39 into microsoft:main Jul 23, 2024
@dong0321

dong0321 commented Aug 9, 2024

Copy link
Copy Markdown

image

Seems to be the same issue. I am building release/0.10 with rocm6.0 dockerfile.

@dong0321

dong0321 commented Aug 9, 2024

Copy link
Copy Markdown

@RyoYang could please check if this need to be fixed also in release/0.10

@dong0321

dong0321 commented Aug 9, 2024

Copy link
Copy Markdown

Build successed after change to 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants