Skip to content

Bug Fix - Update Docker Exec Command for Persistent HPCX Environment#635

Merged
RyoYang merged 3 commits into
microsoft:mainfrom
RyoYang:yangwang1/fix-ld-path
Aug 13, 2024
Merged

Bug Fix - Update Docker Exec Command for Persistent HPCX Environment#635
RyoYang merged 3 commits into
microsoft:mainfrom
RyoYang:yangwang1/fix-ld-path

Conversation

@RyoYang

@RyoYang RyoYang commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

Add 10-hpcx.sh to /etc/profile.d
Update the Docker exec command to ensure a persistent HPCX environment.

@RyoYang
RyoYang requested a review from a team as a code owner August 1, 2024 03:53
@codecov

codecov Bot commented Aug 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (9de841b) to head (0568fdf).

Files Patch % Lines
superbench/runner/runner.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files          97       97           
  Lines        6921     6921           
=======================================
  Hits         5937     5937           
  Misses        984      984           
Flag Coverage Δ
cpu-python3.6-unit-test 71.60% <50.00%> (ø)
cpu-python3.7-unit-test 71.60% <50.00%> (ø)
cpu-python3.8-unit-test 71.63% <50.00%> (ø)
cuda-unit-test 83.86% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread dockerfile/cuda12.2.dockerfile Outdated
@RyoYang
RyoYang enabled auto-merge (squash) August 2, 2024 02:16
@RyoYang

RyoYang commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@cp5555 cp5555 mentioned this pull request Aug 2, 2024
22 tasks
@cp5555 cp5555 added bug Something isn't working containers SuperBench Containers labels Aug 10, 2024
@RyoYang

RyoYang commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@RyoYang

RyoYang commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@RyoYang
RyoYang merged commit 46a5792 into microsoft:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working containers SuperBench Containers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants