feat(Groupper): Moving isIgnoredInput from Mover to utils and reusing it from Groupper.#330
Open
mshoho wants to merge 2 commits into
Open
feat(Groupper): Moving isIgnoredInput from Mover to utils and reusing it from Groupper.#330mshoho wants to merge 2 commits into
mshoho wants to merge 2 commits into
Conversation
bsunderhus
reviewed
Dec 13, 2023
| }; | ||
|
|
||
| handleKeyPress( | ||
| async handleKeyPress( |
Collaborator
There was a problem hiding this comment.
Will this be a breaking change? what version will this PR be bumping?
Collaborator
|
@mshoho are you going to add some tests for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have
isIgnoredInput()that is used to check if Mover needs to handle a key press or not for particular states of the currently focused elements. Reusing this routine for Groupper too and improving the handling logic.