Drop package ref to System.Memory#4651
Merged
Merged
Conversation
Member
Author
|
/backport to rel/3.7 |
Contributor
|
Started backporting to rel/3.7: https://github.com/microsoft/testfx/actions/runs/12785792512 |
Contributor
|
@Evangelink backporting to rel/3.7 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Drop package ref to System.Memory
Using index info to reconstruct a base tree...
M Directory.Packages.props
M test/UnitTests/MSTestAdapter.UnitTests/MSTestAdapter.UnitTests.csproj
Falling back to patching base and 3-way merge...
Auto-merging test/UnitTests/MSTestAdapter.UnitTests/MSTestAdapter.UnitTests.csproj
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Drop package ref to System.Memory
Error: The process '/usr/bin/git' failed with exit code 128NOTE: A PR will be created, but needs to be revised manually!** |
Youssef1313
approved these changes
Jan 15, 2025
Youssef1313
reviewed
Jan 15, 2025
| <PackageReference Include="Moq" /> | ||
| <PackageReference Include="StrongNamer" /> | ||
| <PackageReference Include="System.Memory" /> | ||
| <!-- Fixes "Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies." --> |
Member
There was a problem hiding this comment.
Do we have better understanding on why?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4650