Fix WinUI TestContext.Current being null by Youssef1313 · Pull Request #7749 · microsoft/testfx

Youssef1313 · 2026-04-17T10:49:23Z

No description provided.

Copilot

Pull request overview

This PR addresses a WinUI execution scenario where the ambient TestContext.Current can be null during test execution by ensuring the ITestContext is available directly on TestMethodInfo when invoking the executor.

Changes:

Assigns the runner’s _testContext onto the TestMethodInfo instance immediately before executing the test method.
Reworks TestMethodInfo.TestContext from a static accessor into an instance property that can use an explicitly assigned context, with a fallback to TestContext.Current.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodRunner.cs	Sets `testMethodInfo.TestContext` before invoking the `TestMethodAttribute` executor.
src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs	Converts `TestContext` to an instance property backed by a stored context, falling back to `TestContext.Current`.

Evangelink

Overall the fix looks correct and well-targeted. The approach of using an instance field with AsyncLocal fallback is clean and maintains backward compatibility for non-WinUI scenarios.

A few observations:

Missing tests: There are no unit tests covering the new behavior. A test in TestMethodRunnerTests that verifies TestContext is properly set on the TestMethodInfo before executor invocation would help prevent regression. Specifically, a test showing the fallback works when TestContext.Current is null but field is set would directly validate the WinUI fix.
PR description: The body is currently empty (template placeholder). It would help reviewers to add root cause context — specifically that AsyncLocal doesn't flow through WinUI's DispatcherQueue.TryEnqueue, causing TestContext.Current to be null on the dispatcher thread.
Minor: The field is never cleared after execution, but since TestMethodInfo is created fresh per test (via TypeCache.ResolveTestMethodInfo), there's no stale state risk. No action needed.

Looks good modulo tests and documentation. 🎉 Temperature: warm/supportive. Sentiment: approving with minor suggestions.

Youssef1313 · 2026-04-17T12:15:40Z

@Evangelink I'll let you complete this by copying the tests that Copilot originally wrote in the other PR (please ensure the tests will fail on current main).

…estContext

Evangelink · 2026-04-17T17:55:58Z

@copilot fix these issues:

Check failure on line 195 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs#L195

test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs(195,1): error : [TestMethodInfoInvokeShouldWaitForAsyncTestMethodsToComplete] [net462] This program location is thought to be unreachable. File='/_/src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs' Line=58
Check failure on line 214 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs#L214

test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs(214,1): error : [TestMethodInfoInvokeAsyncShouldHandleThrowAssertInconclusive] [net462] This program location is thought to be unreachable. File='/_/src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs' Line=58
Check failure on line 234 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs#L234

test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs(234,1): error : [TestMethodInfoInvokeAsyncShouldHandleAssertInconclusive] [net462] This program location is thought to be unreachable. File='/_/src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs' Line=58
Check failure on line 252 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs#L252

test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs(252,1): error : [TestMethodInfoInvokeShouldHandleThrowAssertInconclusive] [net462] This program location is thought to be unreachable. File='/_/src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs' Line=58
Check failure on line 272 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs#L272

test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs(272,1): error : [TestMethodInfoInvokeShouldHandleAssertInconclusive] [net462] This program location is thought to be unreachable. File='/_/src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs' Line=58
View more details on Azure Pipelines

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/0103e8e1-f2d9-4a30-9e5d-93ea53c3775f Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-04-17T18:02:42Z

@copilot fix these issues:

[Check failure on line 195 in test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodInfoTests.cs](#7749...

Fixed in ff33e06. I restored the TestMethodInfo.TestContext fallback to TestContext.Current while keeping the runner-set context path, which resolves the net462 unreachable failures you linked.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter TestMethodInfoInvokeShouldWaitForAsyncTestMethodsToComplete|TestMethodInfoInvokeAsyncShouldHandleThrowAssertInconclusive|TestMethodInfoInvokeAsyncShouldHandleAssertInconclusive|TestMethodInfoInvokeShouldHandleThrowAssertInconclusive|TestMethodInfoInvokeSh (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter TestMethodInfoInvokeShouldWaitForAsyncTestMethodsToComplete|TestMethodInfoInvokeAsyncShouldHandleThrowAssertInconclusive|TestMethodInfoInvokeAsyncShouldHandleAssertInconclusive|TestMethodInfoInvokeShouldHandleThrowAssertInconclusive|TestMethodInfoInvokeSh (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 1

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/c216287c-de48-4a49-8c08-d7e369d2edea Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-04-20T11:56:05Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/testfx/testfx/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter FullyQualifiedName~RunTestMethodShouldPassWhenAttributeInvokesTestMethodOnExecutionContextUnsafeThread --nologo (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/testfx/testfx/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter FullyQualifiedName~RunTestMethodShouldPassWhenAttributeInvokesTestMethodOnExecutionContextUnsafeThread --nologo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Evangelink · 2026-04-20T16:22:30Z

@copilot fix

azure-pipelines
/ microsoft.testfx (Build Windows Debug)
test\UnitTests\MSTestAdapter.PlatformServices.UnitTests\Execution\TestMethodRunnerTests.cs#L466

test\UnitTests\MSTestAdapter.PlatformServices.UnitTests\Execution\TestMethodRunnerTests.cs(466,53): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'Task' does not contain a definition for 'WaitAsync' and no accessible extension method 'WaitAsync' accepting a first argument of type 'Task' could be found (are you missing a using directive or an assembly reference?)

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/5400fae9-d407-494c-8bf1-c7b27ec6d7d0 Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-04-20T16:29:21Z

@copilot fix

azure-pipelines
...

Fixed in d206a41: replaced WaitAsync with a Task.WhenAny timeout path so this compiles on net462 while still failing deterministically on hangs. No UI changes to screenshot for this update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/testfx/testfx/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter FullyQualifiedName~RunTestMethodShouldPassWhenAttributeInvokesTestMethodOnExecutionContextUnsafeThread --nologo (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/testfx/testfx/test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/MSTestAdapter.PlatformServices.UnitTests.csproj --filter FullyQualifiedName~RunTestMethodShouldPassWhenAttributeInvokesTestMethodOnExecutionContextUnsafeThread --nologo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 0 new

vberkaltun · 2026-04-28T07:59:40Z

Thanks for fixing this issue!

Is there a plan to release a new stable version with this fix soon? It would be great if a release is planned for this week. Otherwise, I will stay on 4.1.0 for now and avoid using 4.2.1 until a version with the fix is available.

Evangelink · 2026-04-28T14:08:29Z

/backport to rel/4.2

Evangelink · 2026-04-28T14:09:54Z

/backport to rel/4.2

github-actions · 2026-04-28T14:10:14Z

Started backporting to rel/4.2: https://github.com/microsoft/testfx/actions/runs/25057861590

Evangelink · 2026-04-28T14:32:03Z

Thanks for fixing this issue!

Is there a plan to release a new stable version with this fix soon? It would be great if a release is planned for this week. Otherwise, I will stay on 4.1.0 for now and avoid using 4.2.1 until a version with the fix is available.

Yes sorry I am quite burried with work, I'm queueing that now

…ckport to rel/4.2) (#7905) Co-authored-by: Youssef1313 <youssefvictor00@gmail.com> Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

vberkaltun · 2026-04-29T08:40:39Z

Yes sorry I am quite burried with work, I'm queueing that now

No problem, that would be great if possible. I will keep an eye on the release this week.

Evangelink · 2026-04-29T09:23:56Z

There was an issue with the release pipeline, I'm looking at it now

Fix WinUI TestContext.Current being null

d692bf5

Copilot AI review requested due to automatic review settings April 17, 2026 10:49

Youssef1313 mentioned this pull request Apr 17, 2026

Prevent UITestMethod false failures when test invocation hops execution context #7746

Closed

Copilot started reviewing on behalf of Youssef1313 April 17, 2026 10:49 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodRunner.cs

Evangelink reviewed Apr 17, 2026

View reviewed changes

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodRunner.cs

Youssef1313 commented Apr 17, 2026

View reviewed changes

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodInfo.cs

Remove AsyncLocal fallback and add regression test for cross-thread T…

8b1d7e9

…estContext

Copilot started work on behalf of Evangelink April 17, 2026 17:56 View session

Restore TestContext.Current fallback in TestMethodInfo

ff33e06

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/0103e8e1-f2d9-4a30-9e5d-93ea53c3775f Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 17, 2026 18:02

Youssef1313 removed the request for review from Copilot April 17, 2026 18:02

Copilot finished work on behalf of Evangelink April 17, 2026 18:03

Copilot AI requested a review from Evangelink April 17, 2026 18:03

Fix test

5a3d620

Copilot AI review requested due to automatic review settings April 20, 2026 10:17

Copilot started reviewing on behalf of Evangelink April 20, 2026 10:18 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestMethodRunnerTests.cs Outdated

Copilot started work on behalf of Evangelink April 20, 2026 11:43 View session

Evangelink marked this pull request as ready for review April 20, 2026 11:43

Copilot AI and others added 2 commits April 20, 2026 11:49

Add timeout and async continuations in unsafe thread test helper

6af9a6e

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/c216287c-de48-4a49-8c08-d7e369d2edea Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Use named timeout constant in unsafe-thread test helper

ad12f2a

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/c216287c-de48-4a49-8c08-d7e369d2edea Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 20, 2026 11:51

Youssef1313 removed the request for review from Copilot April 20, 2026 11:51

Copilot finished work on behalf of Evangelink April 20, 2026 11:56

Copilot started work on behalf of Evangelink April 20, 2026 16:22 View session

Replace WaitAsync with Task.WhenAny timeout for net462 compatibility

d206a41

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/5400fae9-d407-494c-8bf1-c7b27ec6d7d0 Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 20, 2026 16:29

Youssef1313 removed the request for review from Copilot April 20, 2026 16:29

Copilot finished work on behalf of Evangelink April 20, 2026 16:30

Fix code

e24aa4e

Copilot AI review requested due to automatic review settings April 21, 2026 08:22

Copilot started reviewing on behalf of Evangelink April 21, 2026 08:23 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Evangelink enabled auto-merge April 21, 2026 09:17

Evangelink approved these changes Apr 21, 2026

View reviewed changes

Evangelink merged commit c46d03b into main Apr 21, 2026
14 checks passed

Evangelink deleted the dev/ygerges/fix-winui branch April 21, 2026 09:17

Evangelink mentioned this pull request Apr 24, 2026

UITestMethod broken #7744

Closed

nohwnd-bot mentioned this pull request Apr 28, 2026

Fix WinUI TestContext.Current being null by @Youssef1313 in #7749 (backport to rel/4.2) #7905

Merged

Evangelink mentioned this pull request May 11, 2026

Update changelogs for v4.2.2 release #8132

Merged

Uh oh!

Conversation

Youssef1313 commented Apr 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Evangelink left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Youssef1313 commented Apr 17, 2026

Uh oh!

Uh oh!

Evangelink commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI commented Apr 20, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Evangelink commented Apr 20, 2026

Uh oh!

Copilot AI commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

vberkaltun commented Apr 28, 2026

Uh oh!

Evangelink commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Evangelink commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Evangelink commented Apr 28, 2026

Uh oh!

vberkaltun commented Apr 29, 2026

Uh oh!

Evangelink commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Apr 17, 2026 •

edited

Loading

Copilot AI commented Apr 20, 2026 •

edited

Loading

Evangelink commented Apr 28, 2026 •

edited

Loading