Skip to content

Fix CommandLineOptionIsReserved provider placeholder and align validator message assertions #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 3 commits into from
Apr 23, 2026
Merged

Fix CommandLineOptionIsReserved provider placeholder and align validator message assertions #7771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4368cb
Initial plan
Copilot Apr 22, 2026
3d6a02d
Fix CommandLineOptionIsReserved placeholder and tests
Copilot Apr 22, 2026
36c87b4
Use exact assertion for reserved options provider message
Copilot Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
<value>You can fix the previous option clash by overriding the option name using the configuration file</value>
</data>
<data name="CommandLineOptionIsReserved" xml:space="preserve">
<value>Option '--{0}' is reserved and cannot be used by providers: '{0}'</value>
<value>Option '--{0}' is reserved and cannot be used by providers: '{1}'</value>
</data>
<data name="CommandLineParserUnexpectedArgument" xml:space="preserve">
<value>Unexpected argument {0}</value>
Expand Down Expand Up @@ -742,4 +742,4 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<data name="WaitDebuggerAttachNotSupportedInBrowserErrorMessage" xml:space="preserve">
<value>Waiting for debugger to attach (TESTINGPLATFORM_WAIT_ATTACH_DEBUGGER=1) is not supported in browser environments.</value>
</data>
</root>
</root>
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">Možnost --{0} je vyhrazená a nelze ji použít zprostředkovateli: {0}</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">Die Option "--{0}" ist reserviert und kann nicht von Anbietern verwendet werden: "{0}"</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">La opción “--{0}” está reservada y los proveedores no la pueden usar: “{0}”</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">L’option « --{0} » est réservée et ne peut pas être utilisée par les fournisseurs : « {0} »</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">L'opzione '--{0}' è riservata e non può essere usata dai provider: '{0}'</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">オプション '--{0}' は予約されており、プロバイダーでは使用できません: '{0}'</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">'--{0}' 옵션은 예약되어 있으므로 공급자 '{0}'이(가) 사용할 수 없습니다.</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">Opcja „--{0}” jest zastrzeżona i nie może być używana przez dostawców: „{0}”</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">A opção '--{0}' está reservada e não pode ser usada pelos provedores: '{0}'</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">Параметр "--{0}" зарезервирован и не может использоваться поставщиками: "{0}"</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">'--{0}' seçeneği ayrılmıştır ve şu sağlayıcılar tarafından kullanılamaz: '{0}'</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">选项“--{0}”是保留的，提供程序不能使用:“{0}”</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsReserved">
<source>Option '--{0}' is reserved and cannot be used by providers: '{0}'</source>
<target state="translated">選項 '--{0}' 已保留，無法供提供者 '{0}' 使用</target>
<source>Option '--{0}' is reserved and cannot be used by providers: '{1}'</source>
<target state="new">Option '--{0}' is reserved and cannot be used by providers: '{1}'</target>
Comment thread
Evangelink marked this conversation as resolved.
<note />
</trans-unit>
<trans-unit id="CommandLineOptionIsUsingReservedPrefix">
Expand Down
4 changes: 2 additions & 2 deletions test/UnitTests/Microsoft.Testing.Platform.UnitTests/CommandLine/CommandLineHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public async Task ParseAndValidateAsync_ReservedOptions_ReturnsFalse()

// Assert
Assert.IsFalse(result.IsValid);
Assert.AreEqual("Option '--help' is reserved and cannot be used by providers: 'help'", result.ErrorMessage);
Assert.AreEqual("Option '--help' is reserved and cannot be used by providers: 'Microsoft Testing Platform command line provider'", result.ErrorMessage);
Comment thread
Evangelink marked this conversation as resolved.
}

[TestMethod]
Expand Down Expand Up @@ -271,7 +271,7 @@ public async Task ParseAndValidateAsync_MultipleReservedOptionsFromDifferentProv

// Assert
Assert.IsFalse(result.IsValid);
Assert.Contains("Option '--help' is reserved and cannot be used by providers: 'help'", result.ErrorMessage);
Assert.AreEqual("Option '--help' is reserved and cannot be used by providers: 'Microsoft Testing Platform command line provider', 'Provider2'", result.ErrorMessage);
}

[TestMethod]
Expand Down