Skip to content

Add MSTEST0064 to prefer async assertions #8256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 17 commits into from
May 18, 2026
Merged

Add MSTEST0064 to prefer async assertions #8256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4bd6683
Initial plan
Copilot May 15, 2026
0da8df4
Add async assertion analyzer
Copilot May 15, 2026
dd56bd5
Address async assertion review feedback
Copilot May 15, 2026
1dd5492
Share async blocking method name constants
Copilot May 15, 2026
96e9fc5
Fix PreferAsyncAssertion review issues
Evangelink May 15, 2026
8debda3
Merge remote-tracking branch 'origin/main' into copilot/add-analyzer-…
Evangelink May 16, 2026
4c1fe75
Plan review feedback fixes
Copilot May 16, 2026
b71536c
Address async assertion review feedback
Copilot May 16, 2026
190da15
Distinguish VB synthetic implicit returns from C# expression-body ret…
May 16, 2026
4bf3ff6
Merge branch 'main' into copilot/add-analyzer-favorizing-async-assert…
Evangelink May 17, 2026
687b203
Address async assertion review feedback
Copilot May 17, 2026
ec68da1
Handle converted async assertion arguments
Copilot May 18, 2026
800c895
Merge branch 'main' into copilot/add-analyzer-favorizing-async-assert…
Evangelink May 18, 2026
ad7dd57
Address async assertion review edge cases
Copilot May 18, 2026
394e045
Incorporate validation feedback
Copilot May 18, 2026
2983e26
Polish async assertion fixes
Copilot May 18, 2026
dc11ebe
Address final validation suggestions
Copilot May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Analyzers/MSTest.Analyzers.CodeFixes/CodeFixResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,7 @@
<data name="RemoveDuplicateTestMethodAttributeFix" xml:space="preserve">
<value>Remove duplicate TestMethod attribute</value>
</data>
</root>
<data name="UseAsyncAssertionFix" xml:space="preserve">
<value>Use async assertion</value>
</data>
</root>
440 changes: 440 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/PreferAsyncAssertionFixer.cs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Transformovat přepsání Execute na ExecuteAsync</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Přidat [TestMethod]</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Transformieren Sie die Überschreibung von „Execute“ in „ExecuteAsync“.</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">„[TestMethod]“ hinzufügen</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Transformar la invalidación "Execute" en "ExecuteAsync"</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Agregar '[TestMethod]'</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Transformer la redéfinition « Execute » en « ExecuteAsync »</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Ajouter « [TestMethod] »</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Trasformare l'override di 'Execute' in 'ExecuteAsync'</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Aggiungi '[TestMethod]'</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">'Execute' オーバーライドを 'ExecuteAsync' に変換する</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">'[TestMethod]' の追加</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">'Execute' 재정의를 'ExecuteAsync'로 변환</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">'[TestMethod]' 추가</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Zmień zastąpienie „Execute” na „ExecuteAsync”</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Dodaj „[TestMethod]”</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Transformar a substituição "Execute" em "ExecuteAsync"</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Adicionar ''[TestMethod]"</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">Преобразовать переопределение "Execute" в "ExecuteAsync"</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">Добавить "[TestMethod]"</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">'Execute' geçersiz kılmasını 'ExecuteAsync' olarak dönüştür</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">'[TestMethod]' ekle</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">将‘Execute’重写为‘ExecuteAsync’</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">添加“[TestMethod]”</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/MSTest.Analyzers.CodeFixes/xlf/CodeFixResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@
<target state="translated">將 'Execute' 覆寫改為 'ExecuteAsync'</target>
<note />
</trans-unit>
<trans-unit id="UseAsyncAssertionFix">
<source>Use async assertion</source>
<target state="new">Use async assertion</target>
<note />
</trans-unit>
<trans-unit id="UseAttributeOnTestMethodFix">
<source>Add '[TestMethod]'</source>
<target state="translated">新增 '[TestMethod]'</target>
Expand Down
6 changes: 6 additions & 0 deletions src/Analyzers/MSTest.Analyzers/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
; Unshipped analyzer release
; https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md

### New Rules

Rule ID | Category | Severity | Notes
--------|----------|----------|-------
MSTEST0064 | Usage | Info | PreferAsyncAssertionAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0064)
1 change: 1 addition & 0 deletions src/Analyzers/MSTest.Analyzers/Helpers/DiagnosticIds.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,5 @@ internal static class DiagnosticIds
public const string UseOSConditionAttributeInsteadOfRuntimeCheckRuleId = "MSTEST0061";
public const string AvoidOutRefTestMethodParametersRuleId = "MSTEST0062";
public const string TestClassConstructorShouldBeValidRuleId = "MSTEST0063";
public const string PreferAsyncAssertionRuleId = "MSTEST0064";
}
Loading