Reset agentics workflows to upstream and add new ones

.github/aw/actions-lock.json

@@ -10,6 +10,11 @@
       "version": "v5.0.5",
       "sha": "27d5ce7f107fe9357f9df03efb73ab90386fccae"
     },
+    "actions/checkout@v4": {
+      "repo": "actions/checkout",
+      "version": "v4",
+      "sha": "34e114876b0b11c390a56381ad16ebd13914f8d5"
+    },
     "actions/checkout@v6.0.2": {
       "repo": "actions/checkout",
       "version": "v6.0.2",
@@ -50,6 +55,11 @@
       "version": "v0.74.8",
       "sha": "efa55847f72aadb03490d955263ff911bf758700"
     },
+    "super-linter/super-linter@v8.5.0": {
+      "repo": "super-linter/super-linter",
+      "version": "v8.5.0",
+      "sha": "61abc07d755095a68f4987d1c2c3d1d64408f1f9"
+    },
     "super-linter/super-linter@v8.6.0": {
       "repo": "super-linter/super-linter",
       "version": "v8.6.0",

.github/workflows/daily-qa.md → .github/workflows/adhoc-qa.md

@@ -1,36 +1,41 @@
 ---
+source: "githubnext/agentics/workflows/adhoc-qa.md@main"
 description: |
-  This workflow performs ad hoc quality assurance by validating project health daily.
+  This workflow performs ad hoc, subjective quality assurance by validating project health daily.
   Checks that code builds and runs, tests pass, documentation is clear, and code
   is well-structured. Creates discussions for findings and can submit draft PRs
   with improvements. Provides continuous quality monitoring throughout development.
 
 on:
   schedule: daily
   workflow_dispatch:
+  permissions:
+    pull-requests: read
+  steps:
+    - id: check
+      run: |
+        MAX_OPEN_PRS=8
+        if [[ "$GITHUB_EVENT_NAME" != "schedule" ]]; then exit 0; fi
+        COUNT=$(gh pr list --repo "$GITHUB_REPOSITORY" --state open --search 'in:title "[adhoc-qa]"' --json number --jq 'length')
+        [[ "$COUNT" -lt "$MAX_OPEN_PRS" ]]
+      # exits 0 if not scheduled or <MAX_OPEN_PRS open PRs, 1 if ≥MAX_OPEN_PRS
+
+if: needs.pre_activation.outputs.check_result == 'success'
 
 timeout-minutes: 15
 
 permissions: read-all
 
-network:
-  allowed:
-    - defaults
-    - "dotnet"
-
-imports:
-  - shared/repo-build-setup.md
+network: defaults
 
 safe-outputs:
-  noop:
-    report-as-issue: false
   mentions: false
   allowed-github-references: []
   create-discussion:
-    title-prefix: "${{ github.workflow }}"
-    category: "announcements"
+    title-prefix: "[adhoc-qa] "
+    category: "q-a"
   add-comment:
-    target: "*"
+    target: "*" # all issues and PRs
     max: 5
   create-pull-request:
     draft: true
@@ -39,18 +44,19 @@
 
 tools:
   github:
-    lockdown: true
-    toolsets: [repos, pull_requests, issues, discussions]
-    min-integrity: none
+    toolsets: [all]
   web-fetch:
   bash: true
+
 ---
 
-# Daily QA
+# Adhoc QA
 
 ## Job Description
 
-Your name is ${{ github.workflow }}. Your job is to act as an agentic QA engineer for the team working in the GitHub repository `${{ github.repository }}`.
+<!-- Note - this file can be customized to your needs. Replace this section directly, or add further instructions here. After editing run 'gh aw compile' -->
+
+Your name is Adhoc QA. Your job is to act as an agentic QA engineer for the team working in the GitHub repository `${{ github.repository }}`.
 
 1. Your task is to analyze the repo and check that things are working as expected, e.g.
 
@@ -76,6 +82,6 @@
 
 4. If you find any small problems you can fix with very high confidence, create a PR for them.
 
-5. Search for any previous "${{ github.workflow }}" open discussions in the repository. Read the latest one. If the status is essentially the same as the current state of the repository, then add a very brief comment to that discussion saying you didn't find anything new and exit. Close all the previous open Daily QA Report discussions.
+5. Search for any previous "[adhoc-qa]" open discussions in the repository. Read the latest one. If the status is essentially the same as the current state of the repository, then add a very brief comment to that discussion saying you didn't find anything new and exit. Close all the previous open QA Report discussions.
 
-6. Create a new discussion with title starting with "${{ github.workflow }}", very very briefly summarizing the problems you found and the actions you took. Use note form. Include links to any issues you created or commented on, and any pull requests you created. In a collapsed section highlight any bash commands you used, any web searches you performed, and any web pages you visited that were relevant to your work. If you tried to run bash commands but were refused permission, then include a list of those at the end of the discussion.
+6. Create a new discussion with title starting with "[adhoc-qa]", very very briefly summarizing the problems you found and the actions you took. Use note form. Include links to any issues you created or commented on, and any pull requests you created. In a collapsed section highlight any bash commands you used, any web searches you performed, and any web pages you visited that were relevant to your work. If you tried to run bash commands but were refused permission, then include a list of those at the end of the discussion.

.github/workflows/agentic_commands.yml

@@ -1,12 +1,10 @@
-# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"v0.74.8","commands":["add-tests","analyze-build-failure","autofix","perf-assist","review","test-assist"],"workflows":["add-tests","autofix.agent","build-failure-analysis-command","daily-perf-improver","daily-test-improver","review.agent"]}
+# gh-aw-commands: {"payload_version":"v1","schema_version":"v1","compiler_version":"v0.74.8","commands":["add-tests","analyze-build-failure","autofix","review"],"workflows":["add-tests","autofix.agent","build-failure-analysis-command","review.agent"]}
 # Routing summary (sorted):
 #   slash commands:
 #     /add-tests -> add-tests [pull_request_comment] reaction=eyes
 #     /analyze-build-failure -> build-failure-analysis-command [pull_request_comment] reaction=eyes
 #     /autofix -> autofix.agent [pull_request_comment] reaction=eyes
-#     /perf-assist -> daily-perf-improver [pull_request_comment] reaction=eyes
 #     /review -> review.agent [pull_request_comment] reaction=eyes
-#     /test-assist -> daily-test-improver [discussion,discussion_comment,issue_comment,issues,pull_request,pull_request_comment,pull_request_review_comment] reaction=eyes
 #   labels:
 #     (none)
 #    ___                   _   _      
@@ -34,18 +32,8 @@
 name: "Agentic Commands"
 
 on:
-  issues:
-    types: [edited, opened, reopened]
   issue_comment:
     types: [created, edited]
-  pull_request:
-    types: [edited, opened, reopened]
-  pull_request_review_comment:
-    types: [created, edited]
-  discussion:
-    types: [created, edited]
-  discussion_comment:
-    types: [created, edited]
 
 permissions: {}
 
@@ -56,8 +44,6 @@ jobs:
       actions: write
       contents: read
       issues: write
-      pull-requests: write
-      discussions: write
 
     steps:
       - name: Checkout repository
@@ -71,7 +57,7 @@ jobs:
       - name: Route slash command
         uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
         env:
-          GH_AW_SLASH_ROUTING: '{"add-tests":[{"workflow":"add-tests","events":["pull_request_comment"],"ai_reaction":"eyes"}],"analyze-build-failure":[{"workflow":"build-failure-analysis-command","events":["pull_request_comment"],"ai_reaction":"eyes"}],"autofix":[{"workflow":"autofix.agent","events":["pull_request_comment"],"ai_reaction":"eyes"}],"perf-assist":[{"workflow":"daily-perf-improver","events":["pull_request_comment"],"ai_reaction":"eyes"}],"review":[{"workflow":"review.agent","events":["pull_request_comment"],"ai_reaction":"eyes"}],"test-assist":[{"workflow":"daily-test-improver","events":["discussion","discussion_comment","issue_comment","issues","pull_request","pull_request_comment","pull_request_review_comment"],"ai_reaction":"eyes"}]}'
+          GH_AW_SLASH_ROUTING: '{"add-tests":[{"workflow":"add-tests","events":["pull_request_comment"],"ai_reaction":"eyes"}],"analyze-build-failure":[{"workflow":"build-failure-analysis-command","events":["pull_request_comment"],"ai_reaction":"eyes"}],"autofix":[{"workflow":"autofix.agent","events":["pull_request_comment"],"ai_reaction":"eyes"}],"review":[{"workflow":"review.agent","events":["pull_request_comment"],"ai_reaction":"eyes"}]}'
           GH_AW_LABEL_ROUTING: '{}'
         with:
           script: |