Skip to content

Disable failure-as-issue reporting for adhoc-qa workflow#8734

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/disable-adhoc-qa-failure-issue
Jun 1, 2026
Merged

Disable failure-as-issue reporting for adhoc-qa workflow#8734
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/disable-adhoc-qa-failure-issue

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes #8703.

The adhoc-qa agentic workflow keeps creating spurious tracking issues (e.g. #8703) when the copilot engine terminates unexpectedly mid-run while reading shell output. These are environment/engine failures with no actionable code change for this repository, so the auto-filed issues are pure noise.

This PR adds report-failure-as-issue: false to the workflow's safe-outputs block (as suggested by the tip at the bottom of #8703 itself) and regenerates adhoc-qa.lock.yml via gh aw compile adhoc-qa --strict (gh-aw v0.76.1, matching the previously compiled version). The only meaningful runtime change is GH_AW_FAILURE_REPORT_AS_ISSUE flipping from "true" to "false"; the rest of the lock diff is expected heredoc/hash churn.

The adhoc-qa workflow has been creating spurious tracking issues (e.g. #8703) when the copilot engine terminates unexpectedly mid-run. These are environment/engine failures with no actionable code change for the repository, so add `report-failure-as-issue: false` to the workflow's `safe-outputs` block to stop the auto-filed issues.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 1, 2026 12:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables auto-filing “workflow failure” tracking issues for the adhoc-qa agentic workflow by setting safe-outputs.report-failure-as-issue: false and regenerating the compiled lock workflow so the runtime environment flips GH_AW_FAILURE_REPORT_AS_ISSUE to "false".

Changes:

  • Add report-failure-as-issue: false to the workflow frontmatter safe-outputs block.
  • Regenerate adhoc-qa.lock.yml so the compiled workflow reflects the updated safe-outputs setting (including GH_AW_FAILURE_REPORT_AS_ISSUE: "false").
Show a summary per file
File Description
.github/workflows/adhoc-qa.md Sets safe-outputs.report-failure-as-issue: false to suppress failure-as-issue reporting for this workflow.
.github/workflows/adhoc-qa.lock.yml Regenerated compiled workflow; reflects the frontmatter change (notably GH_AW_FAILURE_REPORT_AS_ISSUE now "false").

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink Evangelink left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — PR #8734: Disable failure-as-issue reporting for adhoc-qa workflow

Reviewed against all 21 dimensions. No issues found.

Summary

The change is minimal and correct:

  • adhoc-qa.md: report-failure-as-issue: false is added at the correct indentation level (top-level safe-outputs key, not nested under noop). The YAML structure is well-formed.
  • adhoc-qa.lock.yml: GH_AW_FAILURE_REPORT_AS_ISSUE flips from "true" to "false" as expected, and the frontmatter_hash is updated to reflect the source change. The lock file was regenerated via gh aw compile adhoc-qa --strict (v0.76.1, matching the prior compiled version), satisfying the agentic workflow guidelines in CONTRIBUTING.

The intent (suppressing spurious engine-crash issues while preserving all other safety signals) is correctly expressed by the change. No unrelated code was modified. ✅

Generated by Expert Code Review (on open) for issue #8734 · sonnet46 921.6K

@Evangelink Evangelink enabled auto-merge (squash) June 1, 2026 13:25
@Evangelink Evangelink merged commit 7aa17a7 into main Jun 1, 2026
26 of 27 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/disable-adhoc-qa-failure-issue branch June 1, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Adhoc QA failed

3 participants