Skip to content

Disable failure-as-issue for Sub-Issue Closer workflow#9000

Merged
Evangelink merged 1 commit into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-8988-sub-issue-closer-no-failure-issue
Jun 10, 2026
Merged

Disable failure-as-issue for Sub-Issue Closer workflow#9000
Evangelink merged 1 commit into
microsoft:mainfrom
Evangelink:dev/amauryleve/fix-8988-sub-issue-closer-no-failure-issue

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Closes #8988.

Problem

The Sub-Issue Closer is an unattended daily scheduled workflow. Run #27256848324 failed with a transient Docker registry timeout while pulling the node:lts-alpine MCP container image:

Error response from daemon: Get "https://registry-1.docker.io/v2/":
net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Failed to pull node:lts-alpine@sha256:... after 3 attempts
##[error]Process completed with exit code 123.

That is not a code defect, but the workflow's default report-failure-as-issue behaviour filed a noisy [aw] Sub-Issue Closer failed tracking issue regardless.

Fix

Set safe-outputs.report-failure-as-issue: false in sub-issue-closer.md (and regenerate sub-issue-closer.lock.yml via gh aw compile --strict).

This matches the existing pattern already used for similar scheduled / unattended agentic workflows:

  • .github/workflows/adhoc-qa.md
  • .github/workflows/build-failure-analysis.md
  • .github/workflows/build-failure-analysis-command.md

The agentic-workflow tip embedded in #8988 explicitly recommends this exact remediation.

Verification

  • gh aw compile sub-issue-closer --strict → ✓ 0 errors / 0 warnings.
  • grep GH_AW_FAILURE_REPORT_AS_ISSUE sub-issue-closer.lock.yml shows the env var is now emitted as "false".

The Sub-Issue Closer is a scheduled workflow that occasionally fails due to transient infrastructure issues (e.g. Docker registry timeouts when pulling MCP container images such as `node:lts-alpine`). Those infra failures filed noisy `[aw] Sub-Issue Closer failed` tracking issues that are not actionable code defects.

Add `safe-outputs.report-failure-as-issue: false` so transient failures no longer file tracking issues, matching the pattern already used in `adhoc-qa.md`, `build-failure-analysis.md`, and `build-failure-analysis-command.md`.

Fixes microsoft#8988.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 10, 2026 11:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the agentic-workflow “failure-as-issue” behavior for the scheduled Sub-Issue Closer workflow, preventing noisy tracking issues when the run fails due to transient infrastructure problems (e.g., container pull timeouts) rather than a workflow defect.

Changes:

  • Set safe-outputs.report-failure-as-issue: false in .github/workflows/sub-issue-closer.md.
  • Regenerated .github/workflows/sub-issue-closer.lock.yml so the compiled workflow emits GH_AW_FAILURE_REPORT_AS_ISSUE: "false".
Show a summary per file
File Description
.github/workflows/sub-issue-closer.md Adds report-failure-as-issue: false in safe-outputs (consistent with other unattended/scheduled workflows).
.github/workflows/sub-issue-closer.lock.yml Regenerated lockfile reflecting the new frontmatter hash and GH_AW_FAILURE_REPORT_AS_ISSUE: "false" in the compiled workflow.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@Evangelink Evangelink merged commit 6a30ffb into microsoft:main Jun 10, 2026
20 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/fix-8988-sub-issue-closer-no-failure-issue branch June 10, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Sub-Issue Closer failed

2 participants