Transfer ownership in ReflectionMetadataHook.Register instead of cloning by @Evangelink in #9586 (backport to rel/4.3) - #9589
Merged
Evangelink merged 2 commits intoJul 3, 2026
Conversation
The source-gen Register hook defensively cloned every array and dictionary it received. The only sanctioned caller is the MSTest source generator's [ModuleInitializer], which emits fresh, throwaway collections it never mutates, so the copies guarded against a mutation that cannot happen. Store the passed arrays by reference and reuse caller dictionaries when already concrete (AsOwnedDictionary), only materializing exotic IReadOnlyDictionary implementations. The ConstructorInvokerInfo -> ConstructorInvoker projection remains (a representation change, not a defensive copy) but no longer clones parameter arrays. Documents the ownership-transfer contract on the hook. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The API is public and callable from any code; the contract is about ownership and mutation, not caller identity. Clarify accordingly. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9586 to rel/4.3
/cc @Evangelink