Skip to content

docs: add Changed section for MSTEST0050 severity Error→Warning (#9670)#9691

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/scaling-adventure
Jul 7, 2026
Merged

docs: add Changed section for MSTEST0050 severity Error→Warning (#9670)#9691
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/scaling-adventure

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes #9688

PR #9670 lowered MSTEST0050 (GlobalTestFixtureShouldBeValidAnalyzer) from Error to Warning to match the six peer fixture analyzers (MSTEST0008–0013). This severity change is already tracked in AnalyzerReleases.Unshipped.md but was not reflected in docs/Changelog.md.

This PR adds a ### Changed section to the 4.3.0 unreleased entry with one bullet documenting the rule-severity downgrade.

Before: [GlobalTestInitialize]/[GlobalTestCleanup] with invalid signature → build error (hard breaks build)
After: Same → build warning (doesn't fail build unless TreatWarningsAsErrors is set)

…hangelog.md

MSTEST0050 (GlobalTestFixtureShouldBeValidAnalyzer) was lowered from
Error to Warning in #9670 to match the six peer fixture analyzers
(MSTEST0008-0013). This change is tracked in AnalyzerReleases.Unshipped.md
but was missing from the Changelog.md 4.3.0 section.

Fixes #9688

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 7, 2026 07:09
@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 7, 2026
@Evangelink
Evangelink enabled auto-merge (squash) July 7, 2026 07:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing release-note coverage for an analyzer severity change in MSTest’s changelog so that the 4.3.0 (unreleased) entry matches what was already recorded in analyzer release notes.

Changes:

  • Add a new ### Changed section under the 4.3.0 (unreleased) entry.
  • Document the MSTEST0050 severity downgrade from Error to Warning (from PR #9670).
Show a summary per file
File Description
docs/Changelog.md Adds a Changed section for 4.3.0 unreleased and documents the MSTEST0050 severity change.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Low

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

Scope: Documentation-only change (docs/Changelog.md). Verified that:

  • The ### Changed section is correctly placed after ### Fixed per [Keep a Changelog]((keepachangelog.com/redacted) conventions
  • The content accurately reflects the severity change in merged PR #9670 (MSTEST0050: Error → Warning)
  • The PR link and author attribution are correct

@Evangelink
Evangelink merged commit 9f8dd5e into main Jul 7, 2026
23 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/scaling-adventure branch July 7, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: add Changed section for MSTEST0050 severity Error→Warning (#9670)

3 participants