Skip to content

style: use range operators and is-null pattern in new PR files #9737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Jul 8, 2026
Merged

style: use range operators and is-null pattern in new PR files #9737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/MSTestTestNodeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ private static void AddTestMethodIdentifier(TestNode testNode, TestMethod testMe
parameterTypes ??= [];

int lastIndexOfDot = managedType.LastIndexOf('.');
string @namespace = lastIndexOfDot == -1 ? string.Empty : managedType.Substring(0, lastIndexOfDot);
string typeName = lastIndexOfDot == -1 ? managedType : managedType.Substring(lastIndexOfDot + 1);
string @namespace = lastIndexOfDot == -1 ? string.Empty : managedType[..lastIndexOfDot];
string typeName = lastIndexOfDot == -1 ? managedType : managedType[(lastIndexOfDot + 1)..];

// AssemblyFullName and ReturnTypeFullName are not carried by the neutral model today; kept empty to match
// the current (bridge) behavior. Populating them is a follow-up enabled by this native path.
Expand Down Expand Up @@ -305,7 +305,7 @@ private static bool TryParseFullyQualifiedType(string fullyQualifiedName, [NotNu
return false;
}

fullyQualifiedType = fullyQualifiedName.Substring(0, lastDotIndexBeforeOpenBracket);
fullyQualifiedType = fullyQualifiedName[..lastDotIndexBeforeOpenBracket];
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Adapter/MSTestAdapter.PlatformServices/Execution/TestMethodRunner.DataSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private async Task ExecuteTestFromDataSourceAttributeAsync(List<TestResult> resu
try
{
IEnumerable<object>? dataRows = PlatformServiceProvider.Instance.TestDataSource.GetData(_testMethodInfo, _testContext);
if (dataRows == null)
if (dataRows is null)
{
var inconclusiveResult = new TestResult
{
Expand Down