Skip to content

[docs] Update glossary - daily scan 2026-07-09#9772

Merged
Evangelink merged 5 commits into
mainfrom
docs/glossary-daily-scan-2026-07-09-8d9172e177506ef8
Jul 9, 2026
Merged

[docs] Update glossary - daily scan 2026-07-09#9772
Evangelink merged 5 commits into
mainfrom
docs/glossary-daily-scan-2026-07-09-8d9172e177506ef8

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Fixes #9766.

Applies the daily glossary scan for 2026-07-09 originally produced by the Glossary Maintainer workflow (which could not open the PR itself due to GitHub Actions PR-creation restrictions), rebased onto the latest main.

Changes to docs/glossary.md

Added

Updated

  • AzureFoundry — added DefaultAzureCredential / managed-identity authentication details and the three environment variables (AZURE_OPENAI_ENDPOINT, AZURE_OPENAI_DEPLOYMENT_NAME, AZURE_OPENAI_API_KEY) introduced in PR Support managed identity auth in AzureFoundry provider #9707.
  • VSTestBridge — noted that as of MSTest 4.3 MSTest no longer depends on VSTestBridge on the MTP path, while clarifying it is still used by NUnit, Expecto, and third-party adapters.

Reviewer notes

github-actions Bot and others added 2 commits July 9, 2026 10:35
- AzureFoundry: add DefaultAzureCredential/managed identity auth details
  and required environment variables (PR #9707)
- MSTestTestFramework: new entry documenting the native MTP ITestFramework
  for MSTest introduced by RFC 018 (PRs #9706, #9743, #9748, #9755)
- VSTestBridge: note MSTest no longer depends on it on the MTP path
  as of MSTest 4.3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match the existing glossary convention of referencing RFC files as plain backtick paths instead of clickable links whose target (docs/RFCs/...) resolved incorrectly relative to docs/glossary.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 9, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository glossary to reflect recent changes in MSTest’s native Microsoft.Testing.Platform (MTP) integration and AzureFoundry authentication behavior.

Changes:

  • Expanded AzureFoundry entry to document managed identity / DefaultAzureCredential authentication and related environment variables.
  • Added MSTestTestFramework entry describing MSTest’s native ITestFramework path on MTP and the key native seams involved.
  • Updated VSTestBridge entry to clarify MSTest’s removal of the bridge dependency on the MTP path as of MSTest 4.3.
Show a summary per file
File Description
docs/glossary.md Adds/updates glossary entries for AzureFoundry auth, MSTestTestFramework native MTP integration, and VSTestBridge dependency notes.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread docs/glossary.md Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Documentation-only PR — limited-scope review

This PR only modifies docs/glossary.md. Most code-focused review dimensions (threading, security, API compat, performance, etc.) are N/A.

Dimension 17 — Documentation Accuracy

Verified ✓:

  • MSTestTestFramework, MtpUnitTestElementSink, MtpTestResultRecorder, MSTestTestNodeConverter — all class names confirmed in source (src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/).
  • FrameworkTestResult is a valid using-alias for Microsoft.VisualStudio.TestTools.UnitTesting.TestResult in the relevant files.
  • RFC 018 (docs/RFCs/018-Native-MTP-Integration-For-MSTest.md) exists in the repo.
  • Environment variables (AZURE_OPENAI_ENDPOINT, AZURE_OPENAI_DEPLOYMENT_NAME, AZURE_OPENAI_API_KEY, AZURE_CLIENT_ID) confirmed in OpenAIChatClientProvider.cs and PACKAGE.md.
  • DefaultAzureCredential usage confirmed in source.
  • Cross-reference anchors (#vstestbridge#mstesttestframework) resolve correctly.
  • RFC reference format (backtick paths) is consistent with existing glossary entries.
  • Markdown table is well-formed.

One NIT (inline comment): The MSTestTestFramework entry's claim that all five listed MTP interfaces are read "from MTP's IServiceProvider directly" is slightly imprecise — IMessageBus and ITestExecutionFilter come from the ExecuteRequestContext/request objects rather than IServiceProvider.

Dimension 21 — Scope & PR Discipline

✓ Appropriately scoped single-file documentation update. References issue #9766 correctly. PR description accurately summarizes what changed.

Comment thread docs/glossary.md Outdated
IMessageBus and ITestExecutionFilter are read from the per-request ExecuteRequestContext/request objects, not from IServiceProvider. Addresses review feedback on PR #9772.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 9, 2026 08:50
Add explicit subject to the AzureFoundry description for grammatical consistency with neighboring entries. Addresses review feedback on PR #9772.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 3
  • Review effort level: Medium

Comment thread docs/glossary.md Outdated
Comment thread docs/glossary.md Outdated
Comment thread docs/glossary.md Outdated
PR #9755 (dropping the VSTestBridge dependency on the MTP path) merged after the v4.3.0 tag was published, so the native MTP framework ships in the unreleased 4.4.0, not 4.3. Addresses review feedback on PR #9772.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 9, 2026 08:57
@Evangelink
Evangelink enabled auto-merge (squash) July 9, 2026 08:58
@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@Evangelink
Evangelink merged commit f275c50 into main Jul 9, 2026
42 checks passed
@Evangelink
Evangelink deleted the docs/glossary-daily-scan-2026-07-09-8d9172e177506ef8 branch July 9, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Update glossary - daily scan

4 participants