Support php 8.0's "Treat namespaced names as single token" and "?->"#331
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Aug 7, 2020
Merged
Support php 8.0's "Treat namespaced names as single token" and "?->"#331roblourens merged 2 commits intomicrosoft:masterfrom
roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
Without this, tolerant-php-parser won't work in php 8.0. Fixes microsoft#327
See https://wiki.php.net/rfc/nullsafe_operator and the corresponding github implementation PR.
TysonAndre
changed the title
Contributor
Author
|
@roblourens - thoughts? |
Contributor
Author
|
@roblourens - pinging again because this PR fixes issues caused by a major change in lexing and the first php 8.0 beta is out - https://www.php.net/archive/2020.php#2020-08-06-3 |
roblourens
approved these changes
Aug 7, 2020
| // but not switches that mix strings and longs or have unknown longs. | ||
| // Longs are only known if they're declared within the same *class* or an internal constant (tokenizer). | ||
| // | ||
| // For some reason, the SWITCH_LONG opcode was not generated when the expression was part of a class constant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, tolerant-php-parser won't work in php 8.0.
Fixes #327
Fixes #330
I confirmed that SWITCH_LONG opcodes (jumptable optimization) continued to be generated for getTokensArrayFromContent in this patch in php 7.4 and php 8.0 for
php -d opcache.opt_debug_level=0x20000 vendor/bin/phpunit 2>&1|lessSupport php 8.0's nullsafe operator
See https://wiki.php.net/rfc/nullsafe_operator and the corresponding
github implementation PR.