This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Top p bug fix and nice out of the box defaults#16
Merged
Conversation
ilmarinen
commented
May 25, 2021
ilmarinen
commented
- Set temperature to be 1.0 as this prevents repetition in the generated text.
- Set top p to 0.8 and top k to 50 (based on experimentation and info from forums).
- Set max length to 70 (based on experimentation and info from forums. Nice compromise between speed and volume of text returned).
…weak the defaults to generate sentences with minimal repitition
jlema
approved these changes
May 25, 2021
nking-1
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.