Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

Layout fixes and input validation#18

Merged
nking-1 merged 4 commits into
devfrom
layout-fixes
May 25, 2021
Merged

Layout fixes and input validation#18
nking-1 merged 4 commits into
devfrom
layout-fixes

Conversation

@nking-1

@nking-1 nking-1 commented May 25, 2021 •
edited
Loading

Copy link
Copy Markdown
  • Fixes bar chart alignment
  • Adjusts layout of text generation form to match mocks
  • Adds input mask for number text fields to prevent NaN bug
  • Adds sort dropdowns
  • Fixes state bug by moving state into redux store

image

@nking-1
nking-1 requested review from JingyaChen, ilmarinen and jlema May 25, 2021 20:57
@nking-1
nking-1 merged commit 2e579c3 into dev May 25, 2021
@jlema jlema added the enhancement New feature or request label May 25, 2021
@jlema jlema added this to the Eric Demo milestone May 25, 2021
@jlema jlema linked an issue May 25, 2021 that may be closed by this pull request
[interaction] [STRETCH] Filtering and sorting scores #9
Closed
@jlema jlema removed a link to an issue May 25, 2021
[interaction] [STRETCH] Filtering and sorting scores #9
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JingyaChen JingyaChen Awaiting requested review from JingyaChen
2 more reviewers
@ilmarinen ilmarinen ilmarinen approved these changes
@jlema jlema jlema approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

Eric Demo

Development

Successfully merging this pull request may close these issues.

3 participants

@nking-1 @ilmarinen @jlema