Bring back SourceFile.EndOfFileToken

[Mateusz Burzyński (Andarist)]

No description provided.

[Nathan Shively-Sanders (sandersn)]

Still reviewing baselines, but here are some out of order comments.

[Nathan Shively-Sanders (sandersn)]

Requesting changes based on my previous comments, since this batch is just guesses for why diffs have happened.

[Jake Bailey (jakebailey)]

Hm, but this is weird, no?

[Mateusz Burzyński (Andarist)]

it is, the comment above this says the behavior is borked - and the type alias declaration here is the same in Strada:
https://github.com/microsoft/TypeScript/blob/78c16795cdee70b9d9f0f248b6dbb6ba50994a59/tests/baselines/reference/jsDeclarationsDefaultsErr.js#L81-L84

[Jake Bailey (jakebailey)]

Seems like it needs more baseline updates.

[Jake Bailey (jakebailey)]

Still a test failure?

+--- old.partiallyNamedTuples2.types
++++ new.partiallyNamedTuples2.types
+@@= skipped -37, +37 lines =@@
+ const matches = x.get(id1);
+ >matches : Iterable<[id2: string, object]>
+ >x.get(id1) : Iterable<[id2: string, object]>
+->x.get : <Key extends [id1: string, id2: string] | [id1: string] | []>(...key: Key) => GetResult<[id1: string, id2: string], Key, object>
++>x.get : <Key extends [] | [id1: string] | [id1: string, id2: string]>(...key: Key) => GetResult<[id1: string, id2: string], Key, object>
+ >x : MultiKeyMap<[id1: string, id2: string], object>
+->get : <Key extends [id1: string, id2: string] | [id1: string] | []>(...key: Key) => GetResult<[id1: string, id2: string], Key, object>
++>get : <Key extends [] | [id1: string] | [id1: string, id2: string]>(...key: Key) => GetResult<[id1: string, id2: string], Key, object>
+ >id1 : string

Seems to have been a bad merge with main?

[Mateusz Burzyński (Andarist)]

weird, maybe I have forgotten to git add this one single baseline after syncing with main. But either way, this is still blocked on the GetTouchingPropertyName difference - I hope to fix this before Friday but we'll see how it goes

[Jake Bailey (jakebailey)]

The core of this PR is fine, but I think we're still waiting on the removal of the extra unrelated bits?

[Mateusz Burzyński (Andarist)]

Jake Bailey (@jakebailey) I think I addressed everything that had to be addressed here and it should be good to go now

[Jake Bailey (jakebailey)]

What about:

• Bring back SourceFile.EndOfFileToken #1257 (comment)
• Bring back SourceFile.EndOfFileToken #1257 (comment)

[Mateusz Burzyński (Andarist)]

1. this is outdated - I have not included the asked change because all tests pass without it. The change I've made is required by the tests in the codebase
2. this has slipped my mind. I removed this now

[Jake Bailey (jakebailey)]

Thanks!

Stale