Resolve aliases in resolveEntityName until we find the given meaning#4043
Open
ahejlsberg wants to merge 2 commits into
Open
Resolve aliases in resolveEntityName until we find the given meaning#4043ahejlsberg wants to merge 2 commits into
resolveEntityName until we find the given meaning#4043ahejlsberg wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a checker alias-resolution edge case in resolveEntityName that could stop too early along an alias chain and return a symbol without the requested meaning (e.g. type meaning), which surfaced as TS2315 in a CommonJS + JSDoc generics scenario.
Changes:
- Update
Checker.resolveEntityNameto repeatedly resolve aliases until a symbol with the requested meaning is found (or alias resolution stops). - Add a new compiler test reproducing the CommonJS
module.exports+require()+ JSDoc generic typedef scenario. - Add new reference baselines (
.types,.symbols) for the added test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/checker/checker.go |
Resolve alias chains in resolveEntityName until the requested meaning is reached, avoiding premature stop at merged symbols. |
testdata/tests/cases/compiler/cjsExportGenericTypes.ts |
New regression test covering the TS2315 scenario with multiple @template tags and CJS export/require. |
testdata/baselines/reference/compiler/cjsExportGenericTypes.types |
Reference .types baseline for the new test. |
testdata/baselines/reference/compiler/cjsExportGenericTypes.symbols |
Reference .symbols baseline for the new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4038.