Skip to content

Сreate checkers in parallel - #752

Closed
auvred wants to merge 1 commit into
microsoft:mainfrom
auvred:create-checkers-in-parallel
Closed

Сreate checkers in parallel#752
auvred wants to merge 1 commit into
microsoft:mainfrom
auvred:create-checkers-in-parallel

Conversation

@auvred

@auvred auvred commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 5, 2025 08:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread internal/compiler/program.go
@auvred

auvred commented Apr 5, 2025

Copy link
Copy Markdown
Contributor Author

It seems that each checker tries to merge the globals symbol table for all program files (-race tests fail on this). I think this needs to be fixed first. However, creating 16 checkers for the vscode repository takes 50 ms on my machine. So it's not as much of an optimization as I previously thought.

@auvred auvred closed this Apr 5, 2025
@jakebailey

Copy link
Copy Markdown
Member

Oh that race is super interesting, maybe we have that race but are unable to detect it today via the way tests are set up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants