Fail Publish Pipeline if there are Failures When Running in Manual Mode

[jorgerangel-msft]

In https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/eng/pipeline/publish.yml, if the pipeline is triggered in manual mode, the pipeline should fail if it encounters an error. Currently, it will fail with a warning and still open a pr which can give a false positive to reviewers. A clearer signal that something is wrong would be the pipeline failing with an error.

[github-actions]

🎯 Issue Triage

The publish pipeline for http-client-csharp incorrectly continues and opens a PR even when errors occur during manual mode runs, giving reviewers a false positive signal.

Category: Bug

Area: emitter:client:csharp

⚠️ No reproduction provided. A minimal repro would help diagnose this issue.

🔍 Analysis

• File: packages/http-client-csharp/eng/pipeline/publish.yml
• Affected mode: Manual pipeline trigger
• Problem: When run manually and errors are encountered, the pipeline reports a warning-level failure but still proceeds to open a PR — misleading reviewers into thinking the run succeeded.
• Expected behavior: The pipeline should fail with an error and not open a PR when errors are detected in manual mode.
• This is likely a missing error-check or incorrect continueOnError / exit-code handling in the pipeline YAML for the manual trigger condition.

📝 Suggested next steps

• Review the pipeline YAML for the manual trigger path and identify where failures are being swallowed
• Add a step or condition that checks for errors and sets the pipeline result to Failed before the PR-open step
• Test the fix by triggering the pipeline in manual mode with a known failure scenario

Generated by Agentic Triage