Skip to content

Check parse results in parser tests #1314

@nguerrera

Description

@nguerrera

We have a lot of parser tests that only check 1) there are no parse errors 2) various invariants in the parse tree are respected, but they don't assert anything about the shape of the parse tree. Basically everything that uses parseEach without a callback, which is most of the positive parse tests.

You can make these tests pass with completely incorrect results. For example, if you returned an empty script.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions