Retain emitter query param when a playground sample is selected - #10455
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/4401387a-322c-4a76-b29c-d7407abaa1af Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix emitter query parameter not saved with pre-populated samples
Retain emitter query param when a playground sample is selected
Apr 22, 2026
timotheeguerin
approved these changes
Apr 22, 2026
JoshLove-msft
marked this pull request as ready for review
April 22, 2026 23:02
JoshLove-msft
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl and
witemple-msft
as code owners
April 22, 2026 23:02
JoshLove-msft
enabled auto-merge
April 22, 2026 23:02
Collaborator
|
You can try these changes here
|
commit: |
Contributor
|
@copilot run prettier |
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/19ad674f-5550-4aa3-babd-064ffe985b7d Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Contributor
Author
timotheeguerin
approved these changes
Apr 23, 2026
microsoft-github-policy-service
Bot
added
the
stale
Contributor
|
@JoshLove-msft Can you resolve the failure before this is auto-closed? |
Contributor
|
All changed packages have been documented.
Show changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/playground/src/react/standalone.tsxwhereemitterwas being explicitly cleared when asampleNamewas setemitter: undefinedfrom the save logic so the emitter query param is retained alongside?sample=....chronus/changes