feat: add cross-language Spector tests for dollar-sign query params and discriminator without subtypes by iscai-msft · Pull Request #10841 · microsoft/typespec

iscai-msft · 2026-05-29T17:34:56Z

Add two new cross-language Spector test scenarios identified from Go and TypeScript emitter bug fixes:

1. Dollar-sign prefixed query parameters (`parameters/query/DollarSign`)

Tests that emitters correctly handle $-prefixed query parameter names on the wire (e.g. $filter, $top, $skip, $orderby). Common in OData-style APIs.

Identified from: Fix wrong param name for $-prefixed query parameters Azure/autorest.go#1922

2. Discriminated type without subtypes (`type/model/inheritance/single-discriminator`)

Tests a @discriminator-decorated model with no extending subtypes. Emitters should still generate the polymorphic type infrastructure.

Identified from: Fix discriminated type without subtypes not generated as polymorphism type Azure/autorest.go#1892

Both scenarios include main.tsp definitions, mockapi.ts implementations, and updated spec-summary.md.

pkg-pr-new · 2026-05-29T17:36:33Z

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client-js@10841

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-specs@10841

commit: b705846

github-actions · 2026-05-29T17:38:39Z

All changed packages have been documented.

✅ @typespec/http-client-js
✅ @typespec/http-specs

Show changes

`@typespec/http-specs` - feature ✏️

add test for discriminator model without subtypes and query params with $ prefixes

`@typespec/http-client-js` - internal ✏️

skip some spector tests

azure-sdk-automation · 2026-05-29T17:54:39Z

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

Add DollarSign interface to parameters/query with scenarios for $filter, $top/$skip, and $orderby query parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@Discriminator

Add Fish model with @Discriminator but no extending models to single-discriminator tests. Covers get and put scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add parameters/body-root scenario for @bodyRoot nested inside a wrapper model, testing that emitters resolve the accessor path through the wrapper (e.g. body.param) rather than referencing the property name directly. Identified from: Azure/autorest.typescript#3961 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t/cross-language-spector-tests

iscai-msft · 2026-06-03T16:50:54Z

@timotheeguerin the failures in e2e are from the unbranded js emitter. they already have this issue, and they don't have time to fix the unbranded one right now. Is there a way to skip the e2e tests in this case? thanks! cc @JialinHuang803

timotheeguerin · 2026-06-03T17:01:42Z

i think packages/http-client-js/.testignore this file

jhendrixMSFT · 2026-06-10T00:04:00Z

 });
+
+Scenarios.Parameters_Query_SpecialChar_dollarSign = passOnSuccess({
+  uri: "/parameters/query/special-char/dollar-sign",


This path doesn't match the route in the tsp.

CC @iscai-msft

Seems like Copilot should have caught this but it didn't run.

Try to fix it in #10963

…nd body-root nested scenarios (microsoft#10896) This adds python mock API coverage for new Spector scenarios introduced by the cross-language spec updates (PR microsoft#10841): a discriminated model with no declared subtypes, and a `@bodyRoot` parameter nested inside a wrapper model. The PR extends existing single-discriminator tests in both sync and async suites, adds new shared body-root tests, and aligns local spec inputs to a version that contains the scenarios. - **Test coverage: single-discriminator no-subtypes (shared sync/async)** - Extended existing shared tests to cover: - `get_no_subtypes_model()` - `put_no_subtypes_model(...)` - Added `Fish` model assertions to validate the expected wire payload shape (`kind`, `size`). - **Test coverage: body-root nested (shared sync/async)** - Added new shared tests (`test_parameters_body_root.py` and `asynctests/test_parameters_body_root_async.py`) covering the `nested(...)` operation with a `BodyRootModel` (`category`, `link_type`, `was_successful`). - Validated locally against the Spector mock server. - **Spec dependency update for scenario availability** - Updated `@typespec/http-specs` in `packages/http-client-python/package.json` (and lockfile) to a version containing the new scenario definitions used by regeneration. - **Change tracking** - Added a Chronus `internal` entry for `@typespec/http-client-python`. ```python def test_get_no_subtypes_model(client): assert client.get_no_subtypes_model() == Fish(kind="salmon", size=10) def test_put_no_subtypes_model(client): client.put_no_subtypes_model(Fish(kind="salmon", size=10)) def test_nested(client): client.nested(BodyRootModel(category="widget", link_type="hard", was_successful=True)) ``` > Note: The third scenario from PR microsoft#10841, `Parameters_Query_SpecialChar_dollarSign`, is intentionally **not** covered. There is an upstream spec inconsistency where `main.tsp` declares `@route("/dollarSign")` (camelCase) while `mockapi.ts` registers the endpoint at `/dollar-sign` (kebab-case). The mock server only serves `/dollar-sign`, while the generated SDK correctly calls `/dollarSign`, so the test would 404. This requires a fix in `@typespec/http-specs` before SDK coverage can pass. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

…nd discriminator without subtypes (microsoft#10841) Add two new cross-language Spector test scenarios identified from Go and TypeScript emitter bug fixes: ## 1. Dollar-sign prefixed query parameters (`parameters/query/DollarSign`) Tests that emitters correctly handle `$`-prefixed query parameter names on the wire (e.g. `$filter`, `$top`, `$skip`, `$orderby`). Common in OData-style APIs. - Identified from: Azure/autorest.go#1922 ## 2. Discriminated type without subtypes (`type/model/inheritance/single-discriminator`) Tests a `@discriminator`-decorated model with no extending subtypes. Emitters should still generate the polymorphic type infrastructure. - Identified from: Azure/autorest.go#1892 Both scenarios include `main.tsp` definitions, `mockapi.ts` implementations, and updated `spec-summary.md`. --------- Co-authored-by: iscai-msft <isabellavcai@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…nd body-root nested scenarios (microsoft#10896) This adds python mock API coverage for new Spector scenarios introduced by the cross-language spec updates (PR microsoft#10841): a discriminated model with no declared subtypes, and a `@bodyRoot` parameter nested inside a wrapper model. The PR extends existing single-discriminator tests in both sync and async suites, adds new shared body-root tests, and aligns local spec inputs to a version that contains the scenarios. - **Test coverage: single-discriminator no-subtypes (shared sync/async)** - Extended existing shared tests to cover: - `get_no_subtypes_model()` - `put_no_subtypes_model(...)` - Added `Fish` model assertions to validate the expected wire payload shape (`kind`, `size`). - **Test coverage: body-root nested (shared sync/async)** - Added new shared tests (`test_parameters_body_root.py` and `asynctests/test_parameters_body_root_async.py`) covering the `nested(...)` operation with a `BodyRootModel` (`category`, `link_type`, `was_successful`). - Validated locally against the Spector mock server. - **Spec dependency update for scenario availability** - Updated `@typespec/http-specs` in `packages/http-client-python/package.json` (and lockfile) to a version containing the new scenario definitions used by regeneration. - **Change tracking** - Added a Chronus `internal` entry for `@typespec/http-client-python`. ```python def test_get_no_subtypes_model(client): assert client.get_no_subtypes_model() == Fish(kind="salmon", size=10) def test_put_no_subtypes_model(client): client.put_no_subtypes_model(Fish(kind="salmon", size=10)) def test_nested(client): client.nested(BodyRootModel(category="widget", link_type="hard", was_successful=True)) ``` > Note: The third scenario from PR microsoft#10841, `Parameters_Query_SpecialChar_dollarSign`, is intentionally **not** covered. There is an upstream spec inconsistency where `main.tsp` declares `@route("/dollarSign")` (camelCase) while `mockapi.ts` registers the endpoint at `/dollar-sign` (kebab-case). The mock server only serves `/dollar-sign`, while the generated SDK correctly calls `/dollarSign`, so the test would 404. This requires a fix in `@typespec/http-specs` before SDK coverage can pass. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

iscai-msft requested review from bterlson and markcowl as code owners May 29, 2026 17:34

iscai-msft added the lib:http-specs For issues/prs related to the @typespec/http-specs package label May 29, 2026

iscai-msft requested review from AlitzelMendez, chrisradek, timotheeguerin and witemple-msft as code owners May 29, 2026 17:34

JialinHuang803 approved these changes Jun 1, 2026

View reviewed changes

iscai-msft and others added 4 commits June 1, 2026 11:15

feat: add dollar-sign prefixed query parameter Spector tests

b40d857

Add DollarSign interface to parameters/query with scenarios for $filter, $top/$skip, and $orderby query parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

feat: add discriminated type without subtypes Spector test

33a2d33

Add Fish model with @Discriminator but no extending models to single-discriminator tests. Covers get and put scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs: regenerate spec-summary.md

036e75b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

add changeset

a180e1b

iscai-msft force-pushed the feat/cross-language-spector-tests branch from 4662678 to 75dc1ee Compare June 1, 2026 15:16

iscai-msft requested a review from catalinaperalta as a code owner June 1, 2026 15:16

iscai-msft force-pushed the feat/cross-language-spector-tests branch from 75dc1ee to c630cef Compare June 1, 2026 15:28

iscai-msft added 2 commits June 1, 2026 12:11

Merge branch 'main' of https://github.com/microsoft/typespec into fea…

724b131

…t/cross-language-spector-tests

format

ad40f3b

iscai-msft commented Jun 1, 2026

View reviewed changes

Comment thread packages/http-specs/specs/parameters/body-root/main.tsp

tadelesh reviewed Jun 2, 2026

View reviewed changes

Comment thread packages/http-specs/specs/parameters/body-root/main.tsp

Comment thread packages/http-specs/specs/parameters/query/main.tsp Outdated

iscai-msft added 2 commits June 2, 2026 15:42

Merge branch 'main' of https://github.com/microsoft/typespec into fea…

bc1d3ab

…t/cross-language-spector-tests

remove unnecessary tests

1efe1c9

iscai-msft enabled auto-merge June 2, 2026 20:03

timotheeguerin reviewed Jun 2, 2026

View reviewed changes

Comment thread packages/http-specs/specs/parameters/query/main.tsp

iscai-msft requested a review from timotheeguerin June 2, 2026 20:26

tadelesh approved these changes Jun 3, 2026

View reviewed changes

switch to special char

42946e0

iscai-msft added 2 commits June 3, 2026 13:53

ignore tests for unbranded emitter

b32279f

regen summary

8c7d940

iscai-msft requested review from MaryGao, joheredi, qiaozha, timovv and xirzec as code owners June 3, 2026 17:54

microsoft-github-policy-service Bot added the emitter:client:js Issue for the JS client emitter: @typespec/http-client-js label Jun 3, 2026

Create feat-cross-language-spector-tests-2026-5-3-17-55-11.md

b705846

timotheeguerin approved these changes Jun 4, 2026

View reviewed changes

iscai-msft added this pull request to the merge queue Jun 4, 2026

Merged via the queue into microsoft:main with commit 912cf94 Jun 4, 2026
33 checks passed

iscai-msft deleted the feat/cross-language-spector-tests branch June 4, 2026 19:10

msyyc mentioned this pull request Jun 4, 2026

[python] add test case for https://github.com/microsoft/typespec/pull/10841 #10895

Closed

Copilot AI mentioned this pull request Jun 4, 2026

[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios #10896

Merged

jhendrixMSFT reviewed Jun 10, 2026

View reviewed changes

Copilot AI mentioned this pull request Jun 11, 2026

fix(http-specs): change dollarSign query route to match mock API path #10963

Closed

github-actions Bot mentioned this pull request Jun 12, 2026

[Bug][http-specs] CI fails to find mismatch between main.tsp and mockapi.ts #10977

Open

Uh oh!

Conversation

iscai-msft commented May 29, 2026

1. Dollar-sign prefixed query parameters (parameters/query/DollarSign)

2. Discriminated type without subtypes (type/model/inheritance/single-discriminator)

Uh oh!

pkg-pr-new Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@typespec/http-specs - feature ✏️

@typespec/http-client-js - internal ✏️

Uh oh!

azure-sdk-automation Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iscai-msft commented Jun 3, 2026

Uh oh!

timotheeguerin commented Jun 3, 2026

Uh oh!

Uh oh!

jhendrixMSFT Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

msyyc Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

msyyc Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

1. Dollar-sign prefixed query parameters (`parameters/query/DollarSign`)

2. Discriminated type without subtypes (`type/model/inheritance/single-discriminator`)

pkg-pr-new Bot commented May 29, 2026 •

edited

Loading

github-actions Bot commented May 29, 2026 •

edited

Loading

`@typespec/http-specs` - feature ✏️

`@typespec/http-client-js` - internal ✏️

azure-sdk-automation Bot commented May 29, 2026 •

edited

Loading