Skip to content

feat: move internal modifier out of experimental - #10855

Merged
timotheeguerin merged 2 commits into
mainfrom
copilot/move-internal-out-of-experimental
Jun 1, 2026
Merged

feat: move internal modifier out of experimental#10855
timotheeguerin merged 2 commits into
mainfrom
copilot/move-internal-out-of-experimental

Conversation

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

The internal access modifier has been stable with no issues, so it no longer needs the experimental warning. This removes the experimental-feature diagnostic emitted on every use of internal and cleans up all associated suppressions.

Changes

  • modifiers.ts — Remove the block that emitted experimental-feature (messageId: "internal") whenever the internal modifier was used
  • messages.ts — Remove the internal messageId from the experimental-feature diagnostic definition
  • prototypes.tsp — Remove #suppress "experimental-feature" from internal extern dec (decorator declarations were never independently experimental; the suppress was only needed for internal)
  • visibility.tsp, private.decorators.tsp — Retain existing #suppress "experimental-feature" on internal extern fn declarations — function declarations (fn) remain experimental
  • internal.test.ts — Update tests to reflect internal no longer emits any diagnostic; previously-allowed usages that only expected experimental-feature now expect clean compilation
  • access-modifiers.md — Remove the "Suppressing the experimental warning" section

Before / After

// Before: emits experimental-feature warning, requires suppression
#suppress "experimental-feature" "suppress internal warning"
internal model MyInternalModel {}

// After: no warning, no suppression needed
internal model MyInternalModel {}

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added compiler:core Issues for @typespec/compiler meta:website TypeSpec.io updates labels Jun 1, 2026
Copilot AI changed the title [WIP] Remove internal experimental diagnostic and suppressions feat: move internal modifier out of experimental Jun 1, 2026
Copilot AI requested a review from timotheeguerin June 1, 2026 19:06
@pkg-pr-new

pkg-pr-new Bot commented Jun 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/compiler@10855

commit: 9bc7f30

@timotheeguerin
timotheeguerin marked this pull request as ready for review June 1, 2026 19:12
@azure-sdk-automation

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin
timotheeguerin added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit e0fb2d1 Jun 1, 2026
33 checks passed
@timotheeguerin
timotheeguerin deleted the copilot/move-internal-out-of-experimental branch June 1, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler:core Issues for @typespec/compiler meta:website TypeSpec.io updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move internal out of experimental

3 participants