[compiler] Fix some issues with functions - #10880
Merged
witemple-msft merged 2 commits intoJun 5, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
witemple-msft
requested review from
RodgeFu,
bterlson,
catalinaperalta,
iscai-msft,
markcowl and
timotheeguerin
as code owners
June 3, 2026 22:15
microsoft-github-policy-service
Bot
added
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
|
|
You can try these changes here
|
timotheeguerin
approved these changes
Jun 5, 2026
JennyPng
pushed a commit
to JennyPng/typespec
that referenced
this pull request
Jun 10, 2026
- Functions were previously not correctly validating that arguments assigned to the rest parameter constraint were compatible with the constraint. This fixes that issue and adds a regression test. - Function diagnostics were incorrectly targeted in some cases that this change addresses. - Function type signatures in `tspd` were rendered a little bit incorrectly and this PR addresses that. - Function documentation had a few typos that this PR fixes (TypeScript -> TypeSpec, one invalid identifier in an example) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tspdwere rendered a little bit incorrectly and this PR addresses that.