Enable QueryTests dollar-sign test for http-client-java - #11307
Merged
weidongxu-microsoft merged 2 commits intoJul 20, 2026
Merged
Conversation
The @typespec/http-specs dollar-sign route fix is now published (0.1.0-alpha.38), so testDollarSign passes against the mock server. Remove the @disabled annotation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a10e9989-905e-4380-a221-01c04f4da1f7
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
All changed packages have been documented.
Show changes
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a10e9989-905e-4380-a221-01c04f4da1f7
weidongxu-microsoft
marked this pull request as ready for review
July 20, 2026 08:31
weidongxu-microsoft
requested review from
XiaofeiCao,
alzimmermsft and
haolingdong-msft
as code owners
July 20, 2026 08:31
|
You can try these changes here
|
XiaofeiCao
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
parameters.query.QueryTests#testDollarSigntest inhttp-client-generator-clientcore-testwas disabled pending the@typespec/http-specsdollar-sign route fix. That fix is now published (http-specs0.1.0-alpha.38), and the already-generatedSpecialCharClient.dollarSigncode matches the current spec (route/parameters/query/special-char/dollar-sign,@QueryParam("$filter")).This PR removes the
@Disabledannotation (and its now-unused import) to enable the test.Validation
mvn test -Dtest=parameters.query.QueryTestsagainst the spector mock server: 2 run, 0 failures, 0 skipped.