Check custom code when preserving enum member underscores for backcompat - #11315
Merged
jorgerangel-msft merged 6 commits intoJul 20, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix enum member underscore preservation in custom code
Check custom code when preserving enum member underscores for backcompat
Jul 20, 2026
…a testdata Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
commit: |
…tract Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
jorgerangel-msft
requested review from
JoshLove-msft,
joseharriaga and
jsquire
as code owners
July 20, 2026 20:48
JoshLove-msft
approved these changes
Jul 20, 2026
jorgerangel-msft
deleted the
copilot/check-custom-code-preserve-enum-underscores
branch
July 20, 2026 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underscore back-compat pass restores previously-shipped underscore names (e.g.
Tls1_0) when the current spec normalizes them (e.g.Tls10). For extensible enums whose custom code re-adds the underscore member, the restoration renamed the generated member back to the underscore form — colliding with the custom member and removing the generated symbol it referenced.Example custom code that broke:
Changes
EnumProvider.GetBackCompatibleName: new optionalcustomMemberNamesargument; skips the underscore restoration when the restored name already exists in custom code, keeping the generated name.ExtensibleEnumProvider.BuildEnumValues: collects custom member names fromCustomCodeView.Properties(case-insensitive) and threads them through. UsesCustomCodeViewrather thanCanonicalViewto avoid theCanonicalView → Properties → EnumValues → BuildEnumValuesrecursion cycle; it contributes the same custom members.BackCompat_ExtensibleEnumCustomCodeTakesPrecedenceOverPreservedUnderscoreswith(Custom)/(Last)TestData; existingBackCompat_ExtensibleEnumUnderscoresPreservedremains as the no-custom-code case.