Fix lockfile containing bad feed url and add check to make sure never merged by mistake that way - #11321
Merged
Merged
Conversation
timotheeguerin
changed the title
timotheeguerin
marked this pull request as ready for review
July 21, 2026 01:00
timotheeguerin
requested review from
bterlson,
catalinaperalta,
iscai-msft,
markcowl and
witemple-msft
as code owners
July 21, 2026 01:00
timotheeguerin
enabled auto-merge
July 21, 2026 01:00
Contributor
|
No changes needing a change description found. |
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-lock.yamlto remove registry-proxy-injectedtarball:URLs (load-balancedms-feed-N.pkgs.visualstudio.comhosts) that are environment-specific and break CI. The lockfile is now integrity-only again.check-lockfilescript (eng/common/scripts/check-lockfile.ts) that fails if anytarball:URL is present inpnpm-lock.yaml.version-consistencyjob inconsistency.yml.Why not a pnpm setting?
pnpm's
lockfile-include-tarball-url=falseis already the default and is known to be flaky when the registry host differs from the tarball host, so it does not reliably prevent this. A lightweight CI guard is the robust option.Validation
pnpm run check-lockfilepasses on the cleaned lockfile.tarball:URL is injected.tsc -p ./tsconfig.eng.json --noEmitpasses.