fix(typespec-vscode): skip vscode e2e tests to unblock CI - #11368
Merged
Conversation
vscode-test-web --quality stable pulls the latest VS Code build with no timeout; the 1.130.0 release hung the E2E CI job indefinitely across unrelated PRs. Skip test:web in test:e2e until it can be safely re-enabled.
microsoft-github-policy-service
Bot
added
the
ide
timotheeguerin
marked this pull request as ready for review
July 23, 2026 14:41
timotheeguerin
requested review from
RodgeFu,
bterlson,
catalinaperalta,
iscai-msft,
lirenhe,
markcowl and
witemple-msft
as code owners
July 23, 2026 14:41
Contributor
|
No changes needing a change description found. |
timotheeguerin
enabled auto-merge
July 23, 2026 14:47
Removing test:web alone was not enough: test:extension also hung on VS Code 1.130.0 because @vscode/test-electron download() resolves the latest build. Pin it to the last-known-good 1.129.1.
Both test:web and test:extension pull the latest VS Code build; the 1.130.0 release hung the E2E CI job indefinitely. Skip the whole vscode e2e task until it can be pinned and timeout-guarded.
timotheeguerin
changed the title
|
You can try these changes here
|
iscai-msft
approved these changes
Jul 23, 2026
This was referenced Jul 24, 2026
iscai-msft
pushed a commit
to iscai-msft/typespec
that referenced
this pull request
Jul 29, 2026
VSCode e2e tests (`test:web` and `test:extension`) were temporarily disabled in microsoft#11368 when CI jobs started hanging indefinitely after the VS Code 1.130.0 release. Re-enabling them now that the issue appears resolved. ## Changes - **`packages/typespec-vscode/package.json`**: Restore `test:e2e` to `pnpm test:web && pnpm test:extension` (reverts the skip echo workaround). The vitest config already guards against hangs with a 240s CI timeout. - **`.chronus`**: Replace the "skip" changelog entry with a "re-enable" entry. <!-- START COPILOT CODING AGENT SUFFIX --> - Mitigate microsoft#11369 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
core / E2E TestsCI job started hanging indefinitely this morning across multiple unrelated PRs.Root cause
The hang is isolated to the
typespec-vscode:test:e2eturbo task, which runs two hosts that both download the latest VS Code build:test:web—vscode-test-web --quality stable(latest web build, no timeout)test:extension— electron VS Code via@vscode/test-electrondownload()(latest stable)VS Code 1.130.0 was published 2026-07-22 15:26 UTC (yesterday's green runs used 1.129.1). The new build breaks both hosts so they never report completion, hanging the runner until timeout.
Confirmed by: in the cancelled runs this morning, every other
test:e2etask completes — onlytypespec-vscode:test:e2enever finishes. Skipping onlytest:webdid not unblock CI (E2E still ran >14 min vs 5m43s for a full green run), showingtest:extensionis affected too.Fix
Skip the whole
typespec-vscodee2e task to unblock CI.Follow-up (not in this PR)
Re-enable the vscode e2e tests with the VS Code version pinned to a known-good build and a timeout guard, plus automation to bump the pin, so a future VS Code release can't silently hang CI again.