fix(standalone): don't add shell config entries on re-run - #11470
Open
timotheeguerin with Copilot wants to merge 3 commits into
Open
fix(standalone): don't add shell config entries on re-run#11470timotheeguerin with Copilot wants to merge 3 commits into
timotheeguerin with Copilot wants to merge 3 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix standalone script to not add to bashrc on second run
fix(standalone): don't add shell config entries on re-run
Jul 30, 2026
timotheeguerin
marked this pull request as ready for review
July 30, 2026 11:08
timotheeguerin
requested review from
catalinaperalta,
iscai-msft,
markcowl and
xirzec
as code owners
July 30, 2026 11:08
|
You can try these changes here
|
Member
|
@copilot run formatter |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Contributor
Author
Done — ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone install script appended
TYPESPEC_PATHto shell config files (.bashrc,.zshrc, etc.) on every run, creating duplicate entries. Additionally, the--skip-shell/-sflag was silently broken due to a variable name mismatch (SKIP_SHELLvsskip_shell).Changes
grep -qF "TYPESPEC_PATH" "$CONF_FILE"and skips if already present, printing an informational message instead--skip-shellflag:parse_args()was settingSKIP_SHELL(uppercase) while the exit check readskip_shell(lowercase) — different variables in bash, so the flag had no effect; normalized toskip_shellthroughout