Skip to content

fix(standalone): don't add shell config entries on re-run - #11470

Open
timotheeguerin with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-bashrc-issue-on-re-run
Open

fix(standalone): don't add shell config entries on re-run#11470
timotheeguerin with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-bashrc-issue-on-re-run

Conversation

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The standalone install script appended TYPESPEC_PATH to shell config files (.bashrc, .zshrc, etc.) on every run, creating duplicate entries. Additionally, the --skip-shell / -s flag was silently broken due to a variable name mismatch (SKIP_SHELL vs skip_shell).

Changes

  • Auto-detect existing shell config: Before appending to shell config files, each shell branch now checks grep -qF "TYPESPEC_PATH" "$CONF_FILE" and skips if already present, printing an informational message instead
  • Fix --skip-shell flag: parse_args() was setting SKIP_SHELL (uppercase) while the exit check read skip_shell (lowercase) — different variables in bash, so the flag had no effect; normalized to skip_shell throughout

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix standalone script to not add to bashrc on second run fix(standalone): don't add shell config entries on re-run Jul 30, 2026
Copilot AI requested a review from timotheeguerin July 30, 2026 01:49
@timotheeguerin
timotheeguerin marked this pull request as ready for review July 30, 2026 11:08
@azure-sdk-automation

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@timotheeguerin

Copy link
Copy Markdown
Member

@copilot run formatter

Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run formatter

Done — ran pnpm format, it normalized 2>/dev/null2> /dev/null to match the rest of the file's style. Committed in 2e35e08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standalone script should not add to bashrc when reruning 2nd time

2 participants