[http-client-csharp] Skip backcompat factories with unavailable types - #11473
Open
JoshLove-msft wants to merge 3 commits into
Open
[http-client-csharp] Skip backcompat factories with unavailable types#11473JoshLove-msft wants to merge 3 commits into
JoshLove-msft wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4da49e5-30c3-4be2-8083-fc61b690f9fa
JoshLove-msft
requested review from
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
July 30, 2026 03:09
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4da49e5-30c3-4be2-8083-fc61b690f9fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4da49e5-30c3-4be2-8083-fc61b690f9fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unavailable-backcompat-typediagnostic when a method is skippedThis prevents the stale model-factory overload exposed by the external type resolution scenario in #11465.
Testing
dotnet test packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/test/Microsoft.TypeSpec.Generator.Tests.csproj(1,784 passed)Azure.AI.Projects.Agentswith the Fix external type resolution failing when the type's dependencies are not deployed with the generator #11465 emitter:BingGroundingTool.cswas deleted andProjectsAgentsModelFactoryno longer referencedProjectsAgentToolFixes #11471