Add shared option to @route and @resetRoute - #1183
Merged
Merged
Conversation
tjprescott
marked this pull request as ready for review
October 19, 2022 18:00
tjprescott
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl,
nguerrera and
timotheeguerin
as code owners
October 19, 2022 18:00
tjprescott
commented
Oct 19, 2022
daviwil
reviewed
Oct 19, 2022
tjprescott
force-pushed
the
rest/RouteUpdate
branch
from
October 19, 2022 18:03
99ad025 to
ee50986
Compare
daviwil
approved these changes
Oct 19, 2022
Co-authored-by: David Wilson <david@daviwil.com>
Member
Author
|
@johanste had concerns about autoroute, but it's a separate code path and I'm not sure autoroute would generate duplicate routes (and if it does, should we let it?) |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/1183/ Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/1183/ |
nguerrera
reviewed
Oct 19, 2022
tjprescott
force-pushed
the
rest/RouteUpdate
branch
from
October 19, 2022 19:46
b57f4f3 to
a93ce2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1133.