Skip to content

Fix: constants is not available in fs/promises in node 16 #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 2 commits into from
Dec 9, 2022
Merged

Fix: constants is not available in fs/promises in node 16 #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b28f514
Fix constnats is not vailalbe in fs/promises
timotheeguerin Dec 9, 2022
b7f32f8
Bump
timotheeguerin Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bundler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"!dist/test/**"
],
"dependencies": {
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@rollup/plugin-virtual": "~3.0.1",
"@rollup/plugin-commonjs": "~23.0.2",
"@rollup/plugin-json": "~5.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/cadl-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@types/vscode": "~1.53.0",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@cadl-lang/internal-build-utils": "~0.3.2",
"eslint": "^8.12.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/compiler/CHANGELOG.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
{
"name": "@cadl-lang/compiler",
"entries": [
{
"version": "0.38.3",
"tag": "@cadl-lang/compiler_v0.38.3",
"date": "Fri, 09 Dec 2022 22:03:04 GMT",
"comments": {
"patch": [
{
"comment": "Fix: `constants` not available in `fs/promise`"
}
]
}
},
{
"version": "0.38.2",
"tag": "@cadl-lang/compiler_v0.38.2",
Expand Down
9 changes: 8 additions & 1 deletion packages/compiler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Change Log - @cadl-lang/compiler

This log was last generated on Fri, 09 Dec 2022 20:43:01 GMT and should not be manually modified.
This log was last generated on Fri, 09 Dec 2022 22:03:04 GMT and should not be manually modified.

## 0.38.3
Fri, 09 Dec 2022 22:03:04 GMT

### Patches

- Fix: `constants` not available in `fs/promise`

## 0.38.2
Fri, 09 Dec 2022 20:43:01 GMT
Expand Down
4 changes: 2 additions & 2 deletions packages/compiler/cmd/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { access, constants, readFile, realpath, stat } from "fs/promises";
import { access, readFile, realpath, stat } from "fs/promises";
import { join, resolve } from "path";
import url from "url";
import { resolveModule, ResolveModuleHost } from "../core/module-resolver.js";
Expand Down Expand Up @@ -28,7 +28,7 @@ export async function runScript(relativePath: string, backupPath: string): Promi
}

function checkFileExists(file: string) {
return access(file, constants.F_OK)
return access(file)
.then(() => true)
.catch(() => false);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cadl-lang/compiler",
"version": "0.38.2",
"version": "0.38.3",
"description": "Cadl Compiler Preview",
"author": "Microsoft Corporation",
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/html-program-viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"!dist/test/**"
],
"peerDependencies": {
"@cadl-lang/compiler": "~0.38.2"
"@cadl-lang/compiler": "~0.38.3"
},
"dependencies": {
"prettier": "~2.7.1",
Expand All @@ -66,7 +66,7 @@
"@types/prettier": "2.6.0",
"@types/react": "~18.0.5",
"@types/react-dom": "~18.0.1",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@babel/core": "^7.0.0",
"eslint": "^8.12.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/library-linter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@
"!dist/test/**"
],
"peerDependencies": {
"@cadl-lang/compiler": "~0.38.2"
"@cadl-lang/compiler": "~0.38.3"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"eslint": "^8.12.0",
"mocha": "~10.1.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/lint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
"!dist/test/**"
],
"peerDependencies": {
"@cadl-lang/compiler": "~0.38.2"
"@cadl-lang/compiler": "~0.38.3"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@cadl-lang/eslint-plugin": "~0.38.0",
"eslint": "^8.12.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/migrate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
],
"dependencies": {
"globby": "~13.1.1",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/compiler-v0.37": "npm:@cadl-lang/compiler@0.37.0"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@cadl-lang/eslint-plugin": "~0.38.0",
"eslint": "^8.12.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/openapi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@
"!dist/test/**"
],
"peerDependencies": {
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@cadl-lang/library-linter": "~0.38.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/openapi3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@
],
"peerDependencies": {
"@cadl-lang/versioning": "~0.38.0",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0",
"@cadl-lang/openapi": "~0.38.0"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0",
"@cadl-lang/openapi": "~0.38.0",
"@cadl-lang/versioning": "~0.38.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
],
"dependencies": {
"@cadl-lang/versioning": "~0.38.0",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0",
"@cadl-lang/openapi3": "~0.38.0",
"@cadl-lang/openapi": "~0.38.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/prettier-plugin-cadl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"prettier": "~2.7.1"
},
"devDependencies": {
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/internal-build-utils": "~0.3.2",
"@rollup/plugin-commonjs": "~23.0.2",
"@rollup/plugin-json": "~5.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@
"!dist/test/**"
],
"peerDependencies": {
"@cadl-lang/compiler": "~0.38.2"
"@cadl-lang/compiler": "~0.38.3"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
"@types/node": "~18.11.9",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/eslint-config-cadl": "~0.5.0",
"@cadl-lang/library-linter": "~0.38.0",
"@cadl-lang/eslint-plugin": "~0.38.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
],
"dependencies": {
"@cadl-lang/versioning": "~0.38.0",
"@cadl-lang/compiler": "~0.38.2",
"@cadl-lang/compiler": "~0.38.3",
"@cadl-lang/rest": "~0.38.0",
"@cadl-lang/openapi": "~0.38.0",
"@cadl-lang/openapi3": "~0.38.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/versioning/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"!dist/test/**"
],
"dependencies": {
"@cadl-lang/compiler": "~0.38.2"
"@cadl-lang/compiler": "~0.38.3"
},
"devDependencies": {
"@types/mocha": "~10.0.0",
Expand Down