Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@typespec/http",
"comment": "**Fix** query format not accepting anything other than `csv` and `multi`",
"type": "none"
}
],
"packageName": "@typespec/http"
}
4 changes: 1 addition & 3 deletions packages/http/src/decorators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ export function $query(
}
const format = queryNameOrOptions.properties.get("format")?.type;
if (format?.kind === "String") {
if (format.value === "multi" || format.value === "csv") {
options.format = format.value;
}
options.format = format.value as any; // That value should have already been validated by the TypeSpec dec
Comment thread
timotheeguerin marked this conversation as resolved.
}
}
}
Expand Down
21 changes: 12 additions & 9 deletions packages/http/test/http-decorators.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,16 +210,19 @@ describe("http: decorators", () => {
strictEqual(getQueryParamName(runner.program, select), "$select");
});

it("override query with QueryOptions", async () => {
const { selects } = await runner.compile(`
@put op test(@test @query({name: "$select", format: "csv"}) selects: string[]): string;
`);
deepStrictEqual(getQueryParamOptions(runner.program, selects), {
type: "query",
name: "$select",
format: "csv",
describe("change format for array value", () => {
["csv", "tsv", "ssv", "pipes"].forEach((format) => {
it(`set query format to "${format}"`, async () => {
const { selects } = await runner.compile(`
op test(@test @query({name: "$select", format: "${format}"}) selects: string[]): string;
`);
deepStrictEqual(getQueryParamOptions(runner.program, selects), {
type: "query",
name: "$select",
format,
});
});
});
strictEqual(getQueryParamName(runner.program, selects), "$select");
});
});

Expand Down