Fix compiler mismatch error recommendation#1858
Merged
timotheeguerin merged 3 commits intoApr 25, 2023
Merged
Conversation
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/1858/ |
timotheeguerin
marked this pull request as ready for review
April 24, 2023 19:36
timotheeguerin
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl and
nguerrera
as code owners
April 24, 2023 19:36
daviwil
reviewed
Apr 25, 2023
| // we have resolved node_modules/@typespec/compiler/dist/core/index.js and we want to get | ||
| // to the shim executable node_modules/.bin/tsp-server | ||
| const betterTypeSpecServerPath = resolvePath(actual.path, ".bin/tsp-server"); | ||
| const betterTypeSpecServerPath = actual.path; |
Contributor
There was a problem hiding this comment.
Does this actually improve the error, though? Seems like it just reverts back to pointing back to the .js file instead. If it does improve things, maybe we can just drop the betterTypeSpecServerPath and use actual.path instead?
Member
Author
There was a problem hiding this comment.
The comment above is actually incorrect, it was not updated last times actual.path is pointing to the compiler/ folder
daviwil
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1853