Error when @versioned is used with @service({version:"X"})#1871
Merged
tjprescott merged 3 commits intoApr 27, 2023
Merged
Conversation
tjprescott
requested review from
allenjzhang,
bterlson,
daviwil,
markcowl,
nguerrera and
timotheeguerin
as code owners
April 27, 2023 16:31
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/1871/ |
tjprescott
force-pushed
the
versioning/IncompatibleDecoratorUsage
branch
2 times, most recently
from
April 27, 2023 16:33
14c25b2 to
bb48872
Compare
…. Fixes microsoft#1866 (for real this time!)
tjprescott
force-pushed
the
versioning/IncompatibleDecoratorUsage
branch
from
April 27, 2023 16:38
bb48872 to
04184bb
Compare
timotheeguerin
approved these changes
Apr 27, 2023
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1866 (for real this time!)
Because it is illogical and contrary to design to have a service version specified in conjunction with
@versioned, here we raise an error diagnostic.cc/ @iscai-msft